-
Notifications
You must be signed in to change notification settings - Fork 39
Force Go standards #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force Go standards #1105
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
mkysel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no opinion
39ca8a4 to
5b6b9d7
Compare
Apply Go naming and package documentation standards across APIs, services, metrics, constants, topics, and tests to align identifiers like HTTPAddr/ID/URL and TopicKind* throughout the codebase
This change standardizes Go naming and documentation across the repository. It renames exported and unexported identifiers to conform to Go conventions (e.g.,
Http→HTTP,Id→ID,Url→URL), replaces legacy topic kind constants withtopic.TopicKind*variants, consolidates retryable error imports underpkg/utils/retryerrors, and adds package-level comments. It also updates constructors, option types, metrics emitters, config types, and test utilities to the new names, and adjusts file names to snake_case for consistency.topic.TopicKind*and updatetopic.TopicKind.String,topic.Topic.IsReserved, and all call sites, including tests (e.g., pkg/topic/topic.go).APIServer,APIServerOption, andHTTPRegistrationFunc, updating constructors and methods across API, gateway, and server layers (e.g., pkg/api/server.go, pkg/api/http_server.go).ID/URL/HTTPnaming across services, metrics, registry nodes, and utils, touching handlers, workers, and tests (e.g., pkg/registry/node.go, pkg/utils/grpc.go).pkg/utils/retryerrorsand update mocks, indexers, and migrator to the new package (e.g., pkg/utils/retryerrors/errors.go).NewPayerAPIService,NewMetadataAPIService) and align tests/utilities (e.g., pkg/api/payer/service.go, pkg/testutils/api/api.go).*SequenceIDand update usages (e.g., pkg/metrics/sync.go).📍Where to Start
Start with the topic kind migration and naming changes in pkg/topic/topic.go, then review API/server renames in pkg/api/server.go and registry node field changes in pkg/registry/node.go.
Macroscope summarized 7ea2571. (Automatic summaries will resume when PR exits draft mode or review begins).