Normalize expiry calculation to UTC with fixed 24h days #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously expiry times were computed using
time.Now().AddDate(...), whichadvances calendar days in local time. This caused expiry drift of ±1h when
crossing DST boundaries (e.g. Nov 2, 2025 in America/New_York), leading to
test failures and inconsistent retention windows.
We now calculate expiry as:
This normalizes to UTC and ensures each "day" of retention is treated as an
exact 24-hour period, independent of daylight saving time changes or local
timezone shifts.
Tests updated accordingly to use the same UTC 24h-day semantics.