Bubble up validation results #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
mkysel
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubble up validation results by returning validator error messages from
message.Service.validateKeyPackageand populatingmlsvalidate.KeyPackageValidationResult.ErrorMessagemessage.Service.validateKeyPackagein service.go to return anInvalidArgumenterror formatted with the first validation result'sErrorMessagewhen the result is not OK.ErrorMessagetomlsvalidate.KeyPackageValidationResultin interface.go.KeyPackageValidationResult.ErrorMessagefrom the gRPC response inmlsvalidate.MLSValidationServiceImpl.ValidateKeyPackagesin service.go.📍Where to Start
Start with
message.Service.validateKeyPackagein service.go to see how the error message is bubbled up, then review the struct change in interface.go and the population logic inmlsvalidate.MLSValidationServiceImpl.ValidateKeyPackagesin service.go.Macroscope summarized 52f8d85.