-
Notifications
You must be signed in to change notification settings - Fork 39
Partial implementation of CLI funds commands #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Add partial CLI funds commands and dual RPC resolution by introducing
|
| logger.Error("could not setup funds admin", zap.Error(err)) | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid or non-hex address inputs cause the handler to silently query the zero address balances instead of reporting an input error.
The balancesHandler calls common.HexToAddress(opts.Address) without validating the string, and HexToAddress maps invalid hex strings to the zero address without an error.
Consider checking the address with common.IsHexAddress and returning an error if it's invalid before calling HexToAddress.
+ if !common.IsHexAddress(opts.Address) {
+ return fmt.Errorf("invalid address: %s", opts.Address)
+ }🚀 Reply to ask Macroscope to explain or update this suggestion.
👍 Helpful? React to give us feedback.
This is getting pretty large so I decided to split off the initial PR.