Skip to content

Conversation

@fbac
Copy link
Collaborator

@fbac fbac commented Sep 23, 2025

Remove the HTTP gateway and construct replication and API servers to serve only gRPC across cmd/replication, pkg/api, pkg/server, and related scripts and tests

This change removes the grpc-gateway HTTP layer across the replication service, API server, builders, configs, and tests, leaving only gRPC listeners and related options. Key updates include deletion of the HTTP server implementation, removal of HTTP listener/registration options and fields, and updates to dev scripts and tests to stop configuring HTTP ports.

📍Where to Start

Start at api.NewAPIServer in server.go, then follow server.startAPIServer in server.go and the replication main in main.go.


Macroscope summarized 6f3c809.

@fbac fbac requested a review from a team as a code owner September 23, 2025 16:33
@graphite-app
Copy link

graphite-app bot commented Sep 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Collaborator

@mkysel mkysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red lines are always good

@fbac fbac merged commit 3df820f into main Sep 24, 2025
11 checks passed
@fbac fbac deleted the 09-23-remove_grpc_gateway branch September 24, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants