Finish withdrawal flow for CLI #1170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
mkysel
force-pushed
the
mkysel/withdrawal-flow
branch
from
1a4e00e to
f13743e
Compare
fbac
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish CLI withdrawal flow by adding
commands.receiveWithdrawalCmdand implementingblockchain.fundsAdmin.Withdrawandblockchain.fundsAdmin.ReceiveWithdrawalfor app-chain initiation and settlement-chain receiptThis change completes the withdrawal flow in the CLI and blockchain layer by wiring app-chain initiation and settlement-chain receipt, updating command UX, and consolidating balance queries to the default signer.
blockchain.fundsAdmin.Withdraw(ctx, amount)to initiate withdrawals viaacg.AppChainGateway.Withdrawandblockchain.fundsAdmin.ReceiveWithdrawal(ctx)to finalize on the settlement chain, with constructorblockchain.NewFundsAdmininitializing the app-chain gateway (funds_admin.go).--amount, implementcommands.withdrawHandler, and introducecommands.receiveWithdrawalCmdwithcommands.receiveWithdrawalHandler; removecheck-withdrawalsand address-based balances (funds.go).currency.FromWeiand add tests and test-only exports forPicoDollarformatting (currency.go, currency_test.go, exports_test.go).FundsAdminand coverage for minting and balances (funds_admin_test.go).📍Where to Start
Start with the CLI flow entry points in
commands.withdrawHandlerandcommands.receiveWithdrawalHandlerin funds.go, then follow intoblockchain.fundsAdmin.Withdrawandblockchain.fundsAdmin.ReceiveWithdrawalin funds_admin.go.Macroscope summarized 1e2ee84.