Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Sep 24, 2025

Gate gRPC server startup behind options.API.Enable and add a deprecation bridge for --replication.enable in cmd/replication/main.go

📍Where to Start

Start in the main function of cmd/replication/main.go to see option consolidation, deprecation handling, and the new API gating, then follow into server.NewReplicationServer in pkg/server/server.go.


Macroscope summarized 7d7a28f.

@mkysel mkysel requested a review from a team as a code owner September 24, 2025 15:55
@graphite-app
Copy link

graphite-app bot commented Sep 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel linked an issue Sep 24, 2025 that may be closed by this pull request
@mkysel mkysel merged commit d457828 into main Sep 24, 2025
11 checks passed
@mkysel mkysel deleted the mkysel/do-not-require-port branch September 24, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xtmpd sync/indexer do not need an API port

3 participants