Fix Identity update StoreLog under HA #1184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a transaction-scoped advisory lock for identity update StoreLog under HA by calling
queries.Queries.AdvisoryLockSequenceand switchingIdentityUpdateStorer.StoreLogto READ COMMITTEDAdvisoryLockSequencein identity_updates.sql that invokespg_advisory_xact_lockusing a composite key ofnode_idandsequence_id.queries.advisoryLockSequenceSQL,queries.AdvisoryLockSequenceParamswithNodeIDandSequenceID, andqueries.Queries.AdvisoryLockSequencemethod to execute the lock.IdentityUpdateStorer.StoreLogin identity_update_storer.go to usesql.LevelReadCommitted, callquerier.AdvisoryLockSequencewithIDENTITY_UPDATE_ORIGINATOR_IDandmsgSent.SequenceId, and return a non-recoverable errorErrAdvisoryLockSequenceon lock failure.📍Where to Start
Start with the transaction flow in
IdentityUpdateStorer.StoreLogin identity_update_storer.go, then review the new SQLC queryAdvisoryLockSequencein identity_updates.sql and its generated method in identity_updates.sql.go.Changes since #1184 opened
Macroscope summarized 79cb8de.