Skip to content

Conversation

@fbac
Copy link
Collaborator

@fbac fbac commented Sep 29, 2025

Add gateway configuration and builder support to enable gRPC server reflection for the Gateway service

  • Add Reflection field to config.GatewayConfig with struct tags group:"Reflection Options" and namespace:"reflection" in gateway.go
  • Add gateway.GatewayServiceBuilder.WithReflection to set b.config.Reflection.Enable in builder.go
  • Update gateway.GatewayServiceBuilder.buildGatewayService to conditionally register gRPC reflection via reflection.Register(grpcServer) and log when enabled in builder.go

📍Where to Start

Start with the service registration path in gateway.GatewayServiceBuilder.buildGatewayService in builder.go.


Macroscope summarized 27d35bc.

@fbac fbac requested a review from a team as a code owner September 29, 2025 17:57
@graphite-app
Copy link

graphite-app bot commented Sep 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@fbac
Copy link
Collaborator Author

fbac commented Sep 29, 2025

Closes #1006

Copy link
Collaborator

@mkysel mkysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easy!

@fbac fbac merged commit 3820974 into main Sep 29, 2025
11 checks passed
@fbac fbac deleted the 09-29-gateway_reflection branch September 29, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants