Skip to content

Conversation

@fbac
Copy link
Collaborator

@fbac fbac commented Oct 2, 2025

Update the Service.GetNodes endpoint to return a map of node IDs to HTTP addresses for the GetNodes endpoint

This change updates the Service.GetNodes handler to return a map keyed by node ID to HTTP address and regenerates associated protocol and OpenAPI definitions to reflect the new response shape.

  • Modify Service.GetNodes to build and return map[uint32]string keyed by node.NodeID instead of a []string of HTTP addresses in service.go
  • Update generated Protobuf to switch GetNodesResponse.Nodes from []string to map[uint32]string with NodesEntry in payer_api.pb.go
  • Update OpenAPI schema to represent GetNodesResponse.nodes as an object with additionalProperties in payer_api.swagger.json

📍Where to Start

Start with the Service.GetNodes handler in service.go.


Macroscope summarized f176dd9.

@fbac fbac requested a review from a team as a code owner October 2, 2025 16:08
@graphite-app
Copy link

graphite-app bot commented Oct 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@fbac fbac merged commit 5d27ea4 into main Oct 2, 2025
11 checks passed
@fbac fbac deleted the 10-02-update_getnodes_proto branch October 2, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants