Fix ErrMessageAtStartSequenceIDNotFound during report generation #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
mkysel
commented
Oct 3, 2025
| // If the start sequence ID is 0, it is the first report and we should start from minute 0 since there are no preceding reports | ||
| var startMinute int32 | ||
| if startEnvelope.OriginatorSequenceID() == 0 { | ||
| if startEnvelope == nil { |
mkysel
commented
Oct 3, 2025
| if err != nil { | ||
| return nil, nil, ErrMessageAtStartSequenceIDNotFound | ||
| } | ||
| var startEnvelope *envelopes.OriginatorEnvelope |
Collaborator
Author
|
All relevant changes are in the |
neekolas
approved these changes
Oct 3, 2025
Contributor
neekolas
left a comment
neekolas
left a comment
There was a problem hiding this comment.
Change makes sense. Thanks for fixing my dumb bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix report verification to avoid
ErrMessageAtStartSequenceIDNotFoundby treatingStartSequenceID == 0as the first report inpayerreport.PayerReportVerifierUpdate report verification to handle first reports without a start envelope and expose types required by tests.
payerreport.PayerReportVerifier.getStartAndEndMessagesto return a nil start envelope whenstartSequenceID == 0, avoiding a lookup and error in verifier.gopayerreport.PayerReportVerifier.verifyMerkleRootto setstartMinute = 0when the start envelope is nil in verifier.gopayerreport.PayerMapand update call sites in generator.go and merkle.gopayerreport.GenerateMerkleTreeTestBinding,payerreport.ValidateReportTransitionTestBinding, andpayerreport.ValidateReportStructureTestBindingin testbindings_test.go📍Where to Start
Start with
payerreport.PayerReportVerifier.getStartAndEndMessagesandpayerreport.PayerReportVerifier.verifyMerkleRootin verifier.go.Macroscope summarized f1bc7dd.