-
Notifications
You must be signed in to change notification settings - Fork 39
Trace failed transactions #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
c99b4e3 to
b99890a
Compare
8ad4927 to
2651129
Compare
mkysel
reviewed
Oct 6, 2025
mkysel
reviewed
Oct 6, 2025
mkysel
reviewed
Oct 6, 2025
mkysel
reviewed
Oct 6, 2025
c3de788 to
717613e
Compare
717613e to
059a81b
Compare
mkysel
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace failed blockchain transactions and return revert output in
pkg/blockchain/client.ExecuteTransactionwith a fixed gas limit of 5,000,000 and a 20s wait timeoutErrTxFailed,ErrTxFailedNoError,ErrTxNotFound, andErrTxGenesisNotTraceablein client.gopkg/blockchain/client.ExecuteTransactionto remove gas estimation and NoSend flow, setGasLimitto 5,000,000, extend wait timeout to 20s, and on mined failure trace viadebug_traceTransactionto return revert output as aBlockchainErrorin client.gopkg/blockchain/client.WaitForTransactionto returnErrTxFailedon failed receipts, treatethereum.NotFoundas a wait condition, and adjust polling behavior in client.gotraceTransactionOutputhelper to polldebug_traceTransactionwithcallTracerand return theoutputfield in client.goBlockchainError.Errorto return only the high-level message in errors.go📍Where to Start
Start with the transaction flow in
ExecuteTransactionin client.go, then reviewWaitForTransactionandtraceTransactionOutputin the same file.Changes since #1211 opened
Macroscope summarized c5a26ff.