Make activeNodeIDs order predictable and fix broken test #1230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort active node IDs in
pkg/payerreport/generator.go::extractActiveNodeIDsto make ordering predictable and return the last submission error frompkg/payerreport/workers/submitter.go::SubmitterWorker.SubmitReportsto fix the broken testThis change introduces deterministic ordering for active node IDs and updates report submission error handling to return the last encountered error after processing all reports.
extractActiveNodeIDsto sort collected node IDs in ascending order after population in generator.goSubmitterWorker.SubmitReportsto track and return the most recent submission error instead of always returningnilin submitter.go📍Where to Start
Start with
extractActiveNodeIDsin generator.go, then reviewSubmitterWorker.SubmitReportsin submitter.go.Macroscope summarized 703b30f.