Attest and submit filters #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fbac
changed the title
fbac
force-pushed
the
10-09-filter_submitted_attestations
branch
from
b17f857 to
01b5ec7
Compare
neekolas
approved these changes
Oct 9, 2025
fbac
force-pushed
the
10-09-filter_submitted_attestations
branch
from
b23d0c8 to
064c5ca
Compare
fbac
force-pushed
the
10-09-filter_submitted_attestations
branch
from
064c5ca to
058e05c
Compare
mkysel
approved these changes
Oct 10, 2025
Collaborator
mkysel
left a comment
mkysel
left a comment
There was a problem hiding this comment.
Love the tests and clarifying comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add submission and attestation filters to limit
AttestationWorker.findReportsNeedingAttestationandSubmitterWorker.SubmitReportsto reports pending attestation and submission for payer report processingThe attestation worker updates its fetch query to require
SubmissionPendingin addition toAttestationPending, and the submitter worker updates its fetch query to requireSubmissionPendingwithAttestationApproved. A new test verifies that reports in non-pending states are excluded and retain their existing statuses.AttestationWorker.findReportsNeedingAttestationto filter reports byAttestationPendingandSubmissionPendingin attestation.goSubmitterWorker.SubmitReportsto fetch onlySubmissionPendingwithAttestationApprovedin submitter.goTestDontAttestReportsInNonPendingStatesin attestation_test.go to verify exclusion of non-pending states📍Where to Start
Start with the fetch logic in
AttestationWorker.findReportsNeedingAttestationin attestation.go, then review the submission filtering inSubmitterWorker.SubmitReportsin submitter.go.📊 Macroscope summarized 058e05c. 2 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.