Submitter state and transition tests #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fbac
force-pushed
the
10-09-submitter_tests
branch
from
1f9e6dd to
183207a
Compare
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
fbac
force-pushed
the
10-09-submitter_tests
branch
from
183207a to
61bc15c
Compare
fbac
force-pushed
the
10-09-submitter_tests
branch
from
61bc15c to
269af44
Compare
added 2 commits
October 10, 2025 16:00
mkysel
approved these changes
Oct 10, 2025
fbac
force-pushed
the
10-09-submitter_tests
branch
from
e515b28 to
9243587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add state and transition tests for
pkg/payerreport/workers.SubmitterWorkerand adjust logging inpkg/payerreport.PayerReportVerifier.isAtMinuteEndThis pull request adds a mock for
pkg/blockchain.PayerReportsManager, introduces a test suite forpkg/payerreport/workers.SubmitterWorkerstate transitions, updates integration tests to use eventual assertions around report generation, preallocates a results map inpkg/payerreport.Storeconversion, and changes the log level inpkg/payerreport.PayerReportVerifier.isAtMinuteEndwhen the expected sequence is not the minute end.PayerReportsManagermock to support worker tests in mock_PayerReportsManager.go and include interface in .mockery.yamlSubmitterWorkercovering valid and invalid outcomes in submitter_test.goGenerateReportsinrequire.Eventuallyfor integration reliability in integration_test.gopayerreport.Storerow conversion in store.gopayerreport.PayerReportVerifier.isAtMinuteEndin verifier.go📍Where to Start
Start with the
SubmitterWorkertests in submitter_test.go, then review thePayerReportsManagermock in mock_PayerReportsManager.go and the verifier change in verifier.go.📊 Macroscope summarized 9243587. 1 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.