Skip to content

Conversation

@github-actions
Copy link
Contributor

  • Nightly Proto Update

Auto-generated by create-pull-request

@github-actions github-actions bot requested a review from a team as a code owner October 16, 2025 10:05
@graphite-app
Copy link

graphite-app bot commented Oct 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Oct 16, 2025

Update protobufs to add GROUP_MEMBERSHIP_STATE_SAVE_PENDING_REMOVE = 5 to device_sync.GroupMembershipStateSave, introduce mls.message_contents.content_types.LeaveRequest, and extend mls.message_contents.GroupUpdated with LeftInboxes

This pull request updates generated protobufs and associated OpenAPI definitions. It adds a new enum value to a device sync message, introduces a new MLS leave request message with an optional authenticated note, and extends a transcript update message with a list of inboxes that left. The OpenAPI Swagger document for the new leave request is added.

  • Add GROUP_MEMBERSHIP_STATE_SAVE_PENDING_REMOVE = 5 to device_sync.GroupMembershipStateSave in group_backup.pb.go
  • Define mls.message_contents.content_types.LeaveRequest with optional authenticated_note (bytes) field in leave_request.pb.go
  • Add LeftInboxes (repeated GroupUpdated_Inbox) to mls.message_contents.GroupUpdated in transcript_messages.pb.go
  • Add Swagger 2.0 scaffold for mls/message_contents/content_types/leave_request.proto in leave_request.swagger.json

📍Where to Start

Start with the enum update in device_sync.GroupMembershipStateSave in group_backup.pb.go, then review the new mls.message_contents.content_types.LeaveRequest definition in leave_request.pb.go, followed by the mls.message_contents.GroupUpdated changes in transcript_messages.pb.go.


📊 Macroscope summarized 62fd0a3. 3 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@fbac fbac closed this Oct 16, 2025
@fbac fbac reopened this Oct 16, 2025
@fbac fbac merged commit a3b07e3 into main Oct 16, 2025
11 checks passed
@fbac fbac deleted the nightly-proto branch October 16, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants