Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Oct 20, 2025

Manually generate proto and OpenAPI schemas to add WelcomePointer variants to MLS API messages and enums across pkg/proto/mls/* and pkg/proto/openapi/*

This change adds new WelcomePointer variants and related enums to MLS API and database proto definitions and updates corresponding OpenAPI swagger schemas. It introduces a new Task message for processing welcome pointers, extends existing messages with oneof variants, and adds enum values for wrapper algorithms and AEAD types, with generated accessors and descriptors updated accordingly.

  • Add WelcomePointer oneof variants and accessors to WelcomeMessage and WelcomeMessageInput in mls.pb.go, including WelcomeMessage_WelcomePointer and WelcomeMessageInput_WelcomePointer messages and WelcomePointerWrapperAlgorithm enum wiring
  • Extend PostCommitAction.Installation with welcome_pointee_encryption_aead_types and getter in intents.pb.go
  • Introduce Task with oneof task containing ProcessWelcomePointer of type message_contents.WelcomePointer in task.pb.go
  • Define WelcomePointeeEncryptionAeadType, WelcomePointerWrapperAlgorithm, and WelcomePointer with WelcomeV1Pointer in welcome_pointer.pb.go, including WelcomePointeeEncryptionAeadTypesExtension
  • Add WELCOME_WRAPPER_ALGORITHM_SYMMETRIC_KEY to WelcomeWrapperAlgorithm in wrapper_encryption.pb.go
  • Update MLS API swagger with WelcomePointer schemas and enums in mls.swagger.json
  • Add swagger for database task in task.swagger.json
  • Add swagger for message contents welcome_pointer in welcome_pointer.swagger.json
  • Update XMTPv4 payer API swagger with WelcomePointer enums and schemas in payer_api.swagger.json

📍Where to Start

Start with the generated MLS API types and oneof wiring in mls.pb.go, then follow the WelcomePointer type definitions in welcome_pointer.pb.go and their use in the new Task message in task.pb.go.


📊 Macroscope summarized d31dc27. 5 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@mkysel mkysel requested a review from a team as a code owner October 20, 2025 14:30
@graphite-app
Copy link

graphite-app bot commented Oct 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit 7fa077c into main Oct 20, 2025
11 checks passed
@mkysel mkysel deleted the mkysel/manual-protos branch October 20, 2025 14:53
@mkysel mkysel mentioned this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants