Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually generate proto and OpenAPI schemas to add
WelcomePointervariants to MLS API messages and enums acrosspkg/proto/mls/*andpkg/proto/openapi/*This change adds new
WelcomePointervariants and related enums to MLS API and database proto definitions and updates corresponding OpenAPI swagger schemas. It introduces a newTaskmessage for processing welcome pointers, extends existing messages withoneofvariants, and adds enum values for wrapper algorithms and AEAD types, with generated accessors and descriptors updated accordingly.WelcomePointeroneof variants and accessors toWelcomeMessageandWelcomeMessageInputin mls.pb.go, includingWelcomeMessage_WelcomePointerandWelcomeMessageInput_WelcomePointermessages andWelcomePointerWrapperAlgorithmenum wiringPostCommitAction.Installationwithwelcome_pointee_encryption_aead_typesand getter in intents.pb.goTaskwithoneof taskcontainingProcessWelcomePointerof typemessage_contents.WelcomePointerin task.pb.goWelcomePointeeEncryptionAeadType,WelcomePointerWrapperAlgorithm, andWelcomePointerwithWelcomeV1Pointerin welcome_pointer.pb.go, includingWelcomePointeeEncryptionAeadTypesExtensionWELCOME_WRAPPER_ALGORITHM_SYMMETRIC_KEYtoWelcomeWrapperAlgorithmin wrapper_encryption.pb.goWelcomePointerschemas and enums in mls.swagger.jsonwelcome_pointerin welcome_pointer.swagger.jsonWelcomePointerenums and schemas in payer_api.swagger.json📍Where to Start
Start with the generated MLS API types and
oneofwiring in mls.pb.go, then follow theWelcomePointertype definitions in welcome_pointer.pb.go and their use in the newTaskmessage in task.pb.go.📊 Macroscope summarized d31dc27. 5 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.