Skip to content

Conversation

@spuradage
Copy link
Contributor

The new version of Go has been optimized, and variables do not need to be reassigned.

For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore

Signed-off-by: spuradage <spuradage@outlook.com>
@spuradage spuradage requested a review from a team as a code owner October 22, 2025 08:58
@graphite-app
Copy link

graphite-app bot commented Oct 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Oct 22, 2025

Remove per-iteration reassignment in blockchain test subtests to omit unnecessary variable rebinding

Refactor test loops to let subtest closures capture the range variable directly by removing tc := tc and tt := tt rebinding lines in blockchain admin and publisher tests, including parallel subtests in blockchain_publisher_test.go.

📍Where to Start

Start with the subtest loops in app_chain_admin_test.go, then review parallel subtests in blockchain_publisher_test.go and related patterns in settlement_chain_admin_test.go.


📊 Macroscope summarized eaaadbb. 0 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@fbac
Copy link
Collaborator

fbac commented Oct 22, 2025

Thank you!

@fbac fbac merged commit f96ba3e into xmtp:main Oct 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants