Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove gateway_time from SQL ordering and order gateway envelope queries by
originator_node_idandoriginator_sequence_idin envelopes_v2.sqlUpdate SQL CTE
ORDER BYto dropgateway_timeand sort byoriginator_node_id,originator_sequence_id; regenerate code and add a test asserting contiguous sequences per originator.📍Where to Start
Start with the
SelectGatewayEnvelopesByOriginatorsandSelectGatewayEnvelopesByTopicsqueries in envelopes_v2.sql, then review the regenerated code in envelopes_v2.sql.go and the test in subscription_test.go.Changes since #1468 opened
TestQueryPagedEnvelopestest assertion [e266456]checkRowsMatchProtoshelper function [e266456]Macroscope summarized 172b3fb.