(via api-Hypernova): Add empty hostname check in measureLatency to prevent localhost dialing #1485
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated from #1483
Add an empty-hostname guard in
ClosestNodeSelectorAlgorithm.measureLatencyto avoid localhost dialing in node_selector.goIntroduce a guard clause that returns
-1when the parsed URL has an empty hostname inClosestNodeSelectorAlgorithm.measureLatencywithin node_selector.go.📍Where to Start
Start at
ClosestNodeSelectorAlgorithm.measureLatencyin node_selector.go.Macroscope summarized ac62651.