Skip to content

(via api-Hypernova): Fix cache overwrite issue and unused parameter linter warnings in node s #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macroscopeapp merged 106 commits into from
Dec 26, 2025
Merged

(via api-Hypernova): Fix cache overwrite issue and unused parameter linter warnings in node s #1486

macroscopeapp merged 106 commits into from
Dec 26, 2025
+32 −23

Conversation

@macroscopeapp
Copy link

@macroscopeapp macroscopeapp bot commented Dec 25, 2025 •
edited
Loading

Originated from #1483

Prevent overwriting ClosestNodeSelectorAlgorithm.updateLatencyCache when all probes fail and mark unused GetNode parameters to satisfy linters in node_selector.go

Add a non-empty guard to ClosestNodeSelectorAlgorithm.updateLatencyCache to retain the previous cache on probe failure and rename unused GetNode parameters to _. Update payer CLI option tag descriptions in options.go.

📍Where to Start

Start with ClosestNodeSelectorAlgorithm.updateLatencyCache in node_selector.go.

Macroscope summarized 7917b40.

@macroscopeapp macroscopeapp bot requested a review from a team as a code owner December 25, 2025 23:20
macroscopeapp bot added 27 commits December 25, 2025 23:22
@macroscopeapp
fix: remove trailing whitespace in node_selector.go and node_selector…
cb051fc 
…_test.go
@macroscopeapp
fix: resolve gofmt and golines lint errors in node_selector_test.go
51a5705
@macroscopeapp
fix: remove trailing whitespace in node_selector_test.go
2d0d3ab
@macroscopeapp
fix: remove trailing blank lines from node_selector_test.go to fix go…
43613c0 
…fmt/gofumpt lint errors
@macroscopeapp
fix: resolve gofmt and gofumpt lint errors in node_selector_test.go
bf200ea
@macroscopeapp
fix: break long require.Equal line in node_selector_test.go for golines
ef34230
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
97fe6d8
@macroscopeapp
fix: properly format PayerOptions struct to fix gofmt and golines lin…
c1f61f9 
…t errors
@macroscopeapp
fix(config): fix gofmt and golines errors in PayerOptions struct
423031b
@macroscopeapp
fix: resolve gofmt and golines lint errors in PayerOptions struct
d5abe3e
@macroscopeapp
fix: align PayerOptions struct fields for golines formatter
57c16f5
@macroscopeapp
fix: remove excessive padding in PayerOptions struct tags for golines…
e43abc2 
… compliance
@macroscopeapp
fix: align PayerOptions struct tags to match golines formatting conve…
7e0fdb5 
…ntions
@macroscopeapp
Fix golines lint error in PayerOptions struct by removing excessive a…
e8eadfa 
…lignment padding
@macroscopeapp
fix: align PayerOptions struct fields consistently to satisfy golines
2a258f6
@macroscopeapp
fix: remove excessive alignment padding in PayerOptions struct to fix…
a98acc2 
… golines lint error
@macroscopeapp
Fix golines lint error in PayerOptions struct by adding internal stru…
a1dff28 
…ct tag alignment
@macroscopeapp
fix: remove excessive struct tag padding in PayerOptions to fix golin…
6c55716 
…es lint
@macroscopeapp
Fix golines lint error in PayerOptions struct with proper internal st…
fbd4c8b 
…ruct tag alignment
@macroscopeapp
fix: remove excessive struct tag padding in PayerOptions to satisfy g…
15d3e41 
…olines
@macroscopeapp
Fix golines lint error in PayerOptions struct by adding internal stru…
5be11ed 
…ct tag alignment
@macroscopeapp
Fix golines formatting error in PayerOptions struct by reducing exces…
08ec704 
…sive padding
@macroscopeapp
fix: remove excessive padding in PayerOptions struct to fix golines l…
3161380 
…int error
@macroscopeapp
fix: properly align PayerOptions struct fields for gofmt compliance
a6e4c7b
@macroscopeapp
fix: align PayerOptions struct fields to fix golines lint error
43cf8c9
@macroscopeapp
fix: remove excessive struct tag alignment in PayerOptions to fix gol…
cdcf94a 
…ines lint
@macroscopeapp
fix: format PayerOptions struct to pass golines linting
b155ff7
macroscopeapp bot added 28 commits December 26, 2025 02:57
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
fe4f39f
@macroscopeapp
fix: format PayerOptions struct to match golines formatting requirements
ea5a63d
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct by creating se…
d821b87 
…parate alignment groups
@macroscopeapp
fix: remove excessive struct tag padding in PayerOptions to satisfy g…
150ab90 
…olines
@macroscopeapp
fix: format PayerOptions struct with consistent alignment to fix goli…
425cfe3 
…nes lint error
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
4c13807
@macroscopeapp
Fix golines lint error in PayerOptions struct by applying consistent …
7e26408 
…field alignment
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
d8bdc04
@macroscopeapp
fix: golines lint error in PayerOptions struct formatting
a2fdb6e
@macroscopeapp
fix: format PayerOptions struct to satisfy golines lint
6fd44e3
@macroscopeapp
fix: format PayerOptions struct to satisfy golines lint
8efb6ac
@macroscopeapp
Fix golines lint error in PayerOptions struct formatting
eebd038
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
4104d31
@macroscopeapp
fix(config): Fix golines lint error in PayerOptions struct by separat…
e227c25 
…ing alignment groups
@macroscopeapp
Fix golines lint error in PayerOptions struct formatting
d747d2f
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
0699bef
@macroscopeapp
fix: align PayerOptions struct fields to match golines formatting con…
5a86c43 
…vention
@macroscopeapp
fix(options): reformat PayerOptions struct to fix golines lint error
d5c8327
@macroscopeapp
fix: restore proper struct tag alignment in PayerOptions to fix golin…
f25dedc 
…es lint error
@macroscopeapp
fix: format PayerOptions struct to satisfy golines lint
7515563
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
6b51bf3
@macroscopeapp
Fix golines lint error in PayerOptions struct formatting
7ad458e
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
4c26e74
@macroscopeapp
Fix golines lint error in PayerOptions by restoring struct tag alignm…
b617619 
…ent on Enable field
@macroscopeapp
Fix golines lint error in PayerOptions struct by aligning all fields
afad52e
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
f0c4c37
@macroscopeapp
fix: resolve golines lint error in PayerOptions struct formatting
7b12b47
@macroscopeapp
fix: correct golines formatting in PayerOptions struct
7917b40
@macroscopeapp macroscopeapp bot merged commit 297eaa2 into hypernova/1475 Dec 26, 2025
11 of 12 checks passed
@macroscopeapp macroscopeapp bot deleted the macroscope/hypernova/1475 branch December 26, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@api-Hypernova api-Hypernova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@api-Hypernova