Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jan 6, 2026

Accept empty strings in flag/env parsing by adding config.Uint32Slice and using it for config.PayerOptions.NodeSelectorPreferredNodes

Add config.Uint32Slice with UnmarshalFlag and String for comma-separated uint32 parsing, and switch PayerOptions.NodeSelectorPreferredNodes to this type in options.go. Parsing trims spaces, skips empty tokens, treats empty input as nil, and errors on non-uint32 tokens; String returns comma-separated values.

📍Where to Start

Start with config.Uint32Slice.UnmarshalFlag in custom_types.go, then review the field change in options.go.


Macroscope summarized b39f6b0.

@mkysel mkysel requested a review from a team as a code owner January 6, 2026 03:04
Copy link
Contributor

@api-Hypernova api-Hypernova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@mkysel mkysel merged commit 3cc062e into main Jan 6, 2026
11 of 12 checks passed
@mkysel mkysel deleted the mkysel/fix-uint-param-array branch January 6, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants