-
Notifications
You must be signed in to change notification settings - Fork 39
Update migrator docs #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update migrator docs #590
Conversation
WalkthroughThe documentation for node registry migration (v2) has been updated to include a new section titled "Set xmtpd cli branch." This section provides instructions for checking out a specific commit of the migrator ( Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
doc/node-registry-migration-v2.md (2)
3-8: Clarify the Section Scope and Rationale.
The new "Set xmtpd cli branch" section is well positioned and clearly indicates the tested migrator commit. To further assist users, consider adding a brief note explaining why this commit (8d6f9252956aa0d7113d56e1deeca887c0d1c888) is recommended—for example, if it contains specific fixes or improvements relevant to the migration.
9-11: Ensure Command Execution Context.
The provided shell command to checkout the specified commit is clear. It might be helpful to remind users that this command should be executed within the correct repository context (i.e., where the migrator code resides) and that they verify the commit exists on the current branch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
doc/node-registry-migration-v2.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build pre-baked anvil-xmtpd
|
|
||
| ## Set xmtpd cli branch | ||
|
|
||
| The migrator has been tested in commit `8d6f9252956aa0d7113d56e1deeca887c0d1c888`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CLI is getting pushed to GHCR.
In general, docs that use docker run are easier to lift and put into some other place as they dont require the repo and golang.
We could also "pin" the version of the docker image in this doc.
Summary by CodeRabbit