Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Apr 10, 2025

Remove GitHub Actions workflow for building and publishing anvil-xmtpd Docker image to eliminate image baking process

Removes the GitHub Actions workflow that was responsible for automatically building and publishing the anvil-xmtpd Docker image to GitHub Container Registry. The workflow previously executed on main branch pushes, pull requests, and manual triggers, handling container registry authentication, Docker metadata extraction, and image building/pushing operations.

📍Where to Start

Start by reviewing the deleted workflow file build-pre-baked-images.yml to understand the CI/CD pipeline being removed.


Macroscope summarized 82f87e1.

libxmtp now uses the contracts image from smart-contracts and no longer depends on a pre-baked image

Summary by CodeRabbit

  • Chores
    • Removed an outdated internal automation workflow to streamline our deployment process and prepare for future efficiency improvements. This update refines our overall build system without altering any visible functionality or interface components. These internal adjustments help maintain a robust and agile deployment pipeline for continued service enhancements.

@mkysel mkysel requested a review from a team as a code owner April 10, 2025 13:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 10, 2025

Walkthrough

The GitHub Actions workflow responsible for building and pushing pre-baked Docker images has been removed. The deleted file defined a workflow that was triggered on pushes to the main branch, pull requests, and manual dispatch, executing steps such as code checkout, registry login, metadata extraction from the Dockerfile, and conditional image build and push operations. Additionally, the Dockerfile and a related Bash script for setting up a local development environment for a blockchain application have also been deleted.

Changes

File(s) Change Summary
.github/workflows/build-pre-baked-images.yml Removed the GitHub Actions workflow that automated the building and pushing of pre-baked Docker images based on various trigger events.
dev/baked/Dockerfile Deleted the Dockerfile that defined a multi-stage build process for creating a Docker image for a blockchain application.
dev/baked/bake.sh Deleted the Bash script that automated the setup of a local development environment for a blockchain application.

Possibly related PRs

  • Pre-baked Anvil+XMTPD docker image #273: The changes in the main PR involve the deletion of a GitHub Actions workflow for building Docker images, while the retrieved PR introduces a new workflow for the same purpose, indicating a direct relationship in terms of functionality and purpose.
  • Fix pre-baked images builder #342: The changes in the main PR involve the deletion of the Dockerfile, while the retrieved PR modifies the same Dockerfile to fix the builder process, indicating a direct relationship between the two.

Suggested reviewers

  • richardhuaaa

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82f87e1 and 5f21d8b.

📒 Files selected for processing (2)
  • dev/baked/Dockerfile (0 hunks)
  • dev/baked/bake.sh (0 hunks)
💤 Files with no reviewable changes (2)
  • dev/baked/Dockerfile
  • dev/baked/bake.sh
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Push Docker Images to GitHub Packages (xmtpd-cli)
  • GitHub Check: Upgrade Tests
  • GitHub Check: Test (Node)
  • GitHub Check: Push Docker Images to GitHub Packages (xmtpd)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@macroscopeapp
Copy link

macroscopeapp bot commented Apr 10, 2025

Remove pre-baked Docker image infrastructure to eliminate image baking process

Removes the infrastructure for creating pre-baked Docker images containing Foundry with XMTPD Node contracts and registrations:

  • Deletes build-pre-baked-images.yml GitHub Actions workflow that built and pushed images to ghcr.io
  • Removes Dockerfile used for creating images with pre-loaded Anvil state
  • Removes bake.sh script that handled local node registration in Anvil instances

📍Where to Start

Start with the GitHub Actions workflow removal in build-pre-baked-images.yml to understand the CI/CD pipeline being removed.


Macroscope summarized 5f21d8b.

@mkysel mkysel merged commit 95c58dd into main Apr 10, 2025
9 checks passed
@mkysel mkysel deleted the mkysel/no-more-baking branch April 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants