Fix docker down

[mkysel]

Modify dev/docker/down script to support multiple Docker Compose profiles and separate project configurations

• Implements profile-based Docker Compose operations in down script, supporting 'single' and 'dual' profiles
• Replaces sourced environment configuration with explicit Docker Compose commands using specific config files
• Separates Docker operations into two distinct commands targeting xmtpd and xmtpd_register_nodes projects
• Configures both commands to use dev/local.env environment file and --remove-orphans --volumes flags

📍Where to Start

Begin by reviewing the main script logic in down which contains the profile handling mechanism and Docker Compose commands.

---

Macroscope summarized cf8f46c.

Summary by CodeRabbit

• New Features
  • Added support for specifying a profile when bringing down Docker Compose projects, with "single" as the default.
• Chores
  • Improved handling of Docker Compose shutdown processes for multiple projects.

[coderabbitai]

Walkthrough

The script dev/docker/down has been updated to accept an optional argument for specifying a profile, with "single" as the default if no valid argument is provided. The script no longer sources the dev/docker/env file. It now brings down two Docker Compose projects: one using docker-compose.yml without a profile, and another using docker-compose-register.yml with the selected profile. Both operations use the same environment file, remove orphan containers, and delete volumes. The Docker Compose project names are explicitly set for each operation.

Changes

File(s)	Change Summary
dev/docker/down	Updated to accept an optional profile argument (default "single"), removed sourcing of env file, and now brings down two Docker Compose projects with explicit project names and profile handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DownScript
    participant DockerComposeMain
    participant DockerComposeRegister

    User->>DownScript: Run script with optional [profile] argument
    DownScript->>DownScript: Determine profile ("single" or "dual", default to "single")
    DownScript->>DockerComposeMain: Bring down main project (docker-compose.yml) with env/local.env
    DownScript->>DockerComposeRegister: Bring down register project (docker-compose-register.yml) with selected profile and env/local.env

Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

dev/docker/down (1)

4-12: Simplify the profile selection logic.

There's redundancy in the current profile handling. Line 4 already sets a default value of "single" with profile=${1:-single}, but then the conditional block potentially overwrites it in all cases.

Additionally, the else branch says it's defaulting to "single" but doesn't explicitly set the variable, relying on line 4 for the default value.

Consider simplifying the logic:

-profile=${1:-single}
-
-if [ "$1" = "single" ]; then
-  profile="single"
-elif [ "$1" = "dual" ]; then
-  profile="dual"
-else
-  echo "No profile provided, defaulting to single"
-fi
+profile=${1:-single}
+
+if [ "$profile" != "single" ] && [ "$profile" != "dual" ]; then
+  echo "Invalid profile '$profile', defaulting to single"
+  profile="single"
+fi

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67cbc6e and cf8f46c.

📒 Files selected for processing (1)

• dev/docker/down (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Push Docker Images to GitHub Packages (xmtpd-cli)
• GitHub Check: Push Docker Images to GitHub Packages (xmtpd)
• GitHub Check: Test (Node)
• GitHub Check: Upgrade Tests

🔇 Additional comments (1)

dev/docker/down (1)

14-25: Docker Compose configuration looks correct.

The Docker Compose commands are properly constructed to bring down two separate projects with appropriate configuration files, environment settings, and project names. The use of --remove-orphans and --volumes flags ensures a clean shutdown.