Skip to content

Conversation

@finnfisher-de
Copy link
Contributor

@finnfisher-de finnfisher-de commented May 8, 2025

I made changes for xmtpd-cli latest version in docker-compose-register.yml file :

  • Updated image tag for register-node-1 service
  • Updated image tag for enable-node-1 service
  • Updated image tag for register-node-2 service
  • Updated image tag for enable-node-2 service

this update ensures all node registration services are using the latest version of the xmtpd-cli tool, which includes recent improvements and bug fixes.
#762

Summary by CodeRabbit

  • Chores
    • Updated the container image version for several services in the Docker Compose configuration.

@finnfisher-de finnfisher-de requested a review from a team as a code owner May 8, 2025 05:22
@graphite-app
Copy link

graphite-app bot commented May 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 8, 2025

Walkthrough

The Docker Compose configuration file was updated to change the container image tag for four services, switching from the previous image tag to a new one. No other modifications were made to the service definitions or configurations.

Changes

File Change Summary
dev/docker/docker-compose-register.yml Updated image tag from sha-7e2f18f to sha-a96bf04 for four services

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to container image tag updates in configuration.

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a96bf04 and fa1999a.

📒 Files selected for processing (1)
  • dev/docker/docker-compose-register.yml (4 hunks)
🔇 Additional comments (1)
dev/docker/docker-compose-register.yml (1)

4-4:

Details

❓ Verification inconclusive

Consistent image tag update; verify tag accessibility and search for residual references.

The image tag for all four services has been updated from sha-7e2f18f to sha-a96bf04, aligning with the PR’s objective. Please ensure that:

  1. The sha-a96bf04 manifest is published and pullable from GitHub Container Registry.
  2. No leftover references to the old tag exist in other compose files, CI pipelines, or deployment scripts.

You can run the following script to confirm the new tag and hunt for any remaining old-tag usages:

Also applies to: 21-21, 39-39, 59-59


🏁 Script executed:

#!/bin/bash
# Verify that the new tag exists
curl -I -H "Accept: application/vnd.oci.image.manifest.v1+json" \
  https://ghcr.io/v2/xmtp/xmtpd-cli/manifests/sha-a96bf04

# Search for any remaining occurrences of the old tag
rg -n 'sha-7e2f18f' || echo "✅ No more references to old tag found."

Length of output: 819


Confirm GHCR image publication & accessibility; no old‐tag references remain

The manifest check for sha-a96bf04 returned HTTP 401 (GHCR v2 API requires authentication), so please verify that this tag is published and pullable by your intended consumers (e.g., via docker pull ghcr.io/xmtp/xmtpd-cli:sha-a96bf04 or with an authenticated API request).

✅ A repository-wide search found no remaining references to the old tag sha-7e2f18f.

Files/lines to review (all four services in dev/docker/docker-compose-register.yml):

  • Line 4
  • Line 21
  • Line 39
  • Line 59

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@macroscopeapp
Copy link

macroscopeapp bot commented May 8, 2025

Update xmtpd-cli Docker image version to sha-a96bf04 in docker-compose-register.yml

Updates the Docker image version for all node registration and enablement services in docker-compose-register.yml from ghcr.io/xmtp/xmtpd-cli:sha-7e2f18f to ghcr.io/xmtp/xmtpd-cli:sha-a96bf04.

📍Where to Start

Review the service configurations in docker-compose-register.yml to verify the image version updates for all four services: register-node-1, enable-node-1, register-node-2, and enable-node-2.


Macroscope summarized fa1999a.

@finnfisher-de
Copy link
Contributor Author

Hi @snormore @mkysel ,
Can you merge if it's ok?

@mkysel mkysel merged commit f783051 into xmtp:main May 8, 2025
7 of 9 checks passed
@coderabbitai coderabbitai bot mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants