Fix problematic tests using risky pattern

[mkysel]

Improve concurrent test error handling in blockchain nonce manager and indexer block tracker tests to fix problematic test patterns

Implements proper error propagation and collection in concurrent test scenarios:

• Modifies TestGetNonce_ConsumeManyConcurrent in nonceManager_test.go to collect and verify goroutine errors through a dedicated error channel instead of using in-goroutine assertions
• Updates TestConcurrentUpdates in block_tracker_test.go to handle concurrent errors via a channel-based collection mechanism and adds early termination on error detection

📍Where to Start

Begin with the TestGetNonce_ConsumeManyConcurrent function in nonceManager_test.go as it contains the core pattern being fixed.

---

Macroscope summarized f32de70.

Summary by CodeRabbit

• Tests
  • Improved error handling in concurrent test scenarios to ensure all errors are collected and reported after test completion, resulting in clearer and more synchronized test results.

[coderabbitai]

Walkthrough

The changes update error handling in concurrent test cases within two test files. Instead of performing immediate error assertions inside goroutines, errors are now collected through channels and checked after all goroutines complete. This centralizes error checking, ensuring all errors are reported collectively after concurrent operations finish.

Changes

Files	Change Summary
pkg/blockchain/nonceManager_test.go	Refactored concurrent test to collect errors from goroutines via a channel and assert after all complete.
pkg/indexer/common/block_tracker_test.go	Updated concurrent test to use a buffered error channel for error collection and centralized assertions post-run.

Possibly related PRs

• Fix TestPublishIdentityUpdate test #607: Modifies nonceManager tests by introducing a heap-based nonce reuse mechanism, related due to changes in nonceManager test logic.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d4717c and f32de70.

📒 Files selected for processing (2)

• pkg/blockchain/nonceManager_test.go (1 hunks)
• pkg/indexer/common/block_tracker_test.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Push Docker Images to GitHub Packages (xmtpd-cli)
• GitHub Check: Upgrade Tests
• GitHub Check: Push Docker Images to GitHub Packages (xmtpd)
• GitHub Check: Test (Node)

🔇 Additional comments (6)

pkg/indexer/common/block_tracker_test.go (3)

81-83: Good improvement: Added error handling channel and explicit WaitGroup

The introduction of a buffered error channel and explicitly declaring the WaitGroup upfront improves the concurrency handling pattern in this test. This is a safer approach than directly asserting errors inside goroutines.

---

96-102: Well-implemented error collection pattern in goroutines

Replacing direct error assertions inside goroutines with an error channel collection pattern is a solid improvement. This approach:

1. Prevents synchronization issues when multiple goroutines might fail
2. Ensures the test reports errors properly rather than potentially terminating in unexpected ways
3. Makes the error flow more explicit and maintainable

The implementation correctly breaks early on first error while still sending the error to the channel, and always sends nil for successful completion.

---

107-110: Good implementation of centralized error checking

Closing the channel after all goroutines have finished and checking all errors in the main test goroutine is the correct approach. This ensures:

1. All errors are properly reported
2. The test doesn't continue if any goroutine encountered an error
3. Error assertions happen in a synchronized way in the main test goroutine

This pattern is much safer for concurrent testing than in-goroutine assertions.

pkg/blockchain/nonceManager_test.go (3)

165-165: Good improvement: Added error handling channel

Creating a buffered error channel with capacity equal to the number of concurrent clients is a solid approach for collecting errors from goroutines.

---

172-180: Well-implemented error collection pattern

The implementation correctly handles potential errors from both the GetNonce and Consume operations by:

1. Sending the error to the channel
2. Returning early from the goroutine to prevent further execution after an error occurs

This approach is much safer than performing assertions inside goroutines.

---

185-188: Good implementation of centralized error checking

Closing the channel after all goroutines have finished and checking all errors in the main test goroutine is the correct pattern. This ensures that all errors are properly reported and assertions happen in a synchronized manner.

This change aligns with the same improvement pattern implemented in the block tracker tests, creating consistency across the codebase.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• Queue - adds this PR to the back of the merge queue
• Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[mkysel]

This is a funny one. The crux of the issue is that calling require or Fatal or anything that kills the thread inside of a goroutine will terminate the goroutine. This means that the main thread sits in the wg.Wait forever.

There are a few patterns on how to avoid this

• don't call require on the goroutine
• use t.Run for each parallel thing instead
• possibly others

All other uses of goroutine spawning is correct in the codebase.