-
Notifications
You must be signed in to change notification settings - Fork 39
Remove paths from CI #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove paths from CI #826
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe pull request updates several GitHub Actions workflow files by removing the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Remove path filtering from GitHub CI workflows to run on all pull requestsModifies GitHub workflow configurations to remove path-based filtering on pull request triggers:
📍Where to StartStart with the pull request trigger configuration in lint-go.yml as it represents the pattern of changes applied across all workflow files. Macroscope summarized 0805238. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/upgrade-test.yml (1)
7-8: Optional: Limit PR triggers to code changes onlyWithout any filters, this workflow will fire on all PR events (comments, labels, reviews, etc.). If you want to restrict runs to actual code updates, consider adding a
types:filter:on: pull_request: types: - opened - synchronize - reopenedThis helps avoid unnecessary CI jobs on non-code events.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/lint-go.yml(1 hunks).github/workflows/lint-spellcheck.yml(1 hunks).github/workflows/nightly.yml(1 hunks).github/workflows/release-from-tag.yml(1 hunks).github/workflows/test.yml(1 hunks).github/workflows/upgrade-test.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test (Node)
🔇 Additional comments (7)
.github/workflows/nightly.yml (1)
6-6: Formatting Adjustment: Added Spacing After TriggerThe blank line after
workflow_dispatch:enhances readability and maintains consistency with other workflow files..github/workflows/release-from-tag.yml (1)
60-60: Formatting Enhancement: Blank Line Beforebuild-argsInserting a blank line improves readability by visually separating
labelsandbuild-argswithin thewithblock. This aligns with formatting in other workflows..github/workflows/lint-spellcheck.yml (1)
6-7: RemovedpathsFilter to Trigger on All Pull RequestsThe
pathsfilter was removed from thepull_requesttrigger, enabling this workflow to run on every PR tomain(regardless of changed files), aligning with the CI simplification objective..github/workflows/test.yml (1)
7-8: RemovedpathsFilter to Broaden PR TriggerBy deleting the
pathsrestriction underpull_requestand adding a blank line, this workflow now runs on all pull requests. This aligns with the intended CI behavior change..github/workflows/lint-go.yml (2)
6-7: RemovedpathsFilter frompull_requestTriggerThe removal of the
pathsrestriction ensures the lint-go workflow runs on any PR tomain, consistent with the CI policy update.
10-10: Formatting Enhancement: Blank Line BetweenpermissionsandjobsAdding a blank line improves visual separation between the
permissionsblock and job definitions..github/workflows/upgrade-test.yml (1)
7-8: Removedpathsfilter to trigger on all pull requestsThe
pathsfilter has been removed under thepull_requestevent, aligning this workflow with the other CI pipelines (lint-go, lint-spellcheck, test) so that upgrade tests run on every PR regardless of which files were modified. Please confirm that this broader trigger is intentional, as it will increase CI runs and may impact resource usage.
This one is for @neekolas
Summary by CodeRabbit