Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented May 20, 2025

This one is for @neekolas

Summary by CodeRabbit

  • Chores
    • Updated workflow triggers so that linting, testing, and upgrade workflows now run on all pull requests to the main branch, regardless of which files are changed.
    • Minor formatting improvements were made to workflow files for consistency.

@mkysel mkysel requested a review from a team as a code owner May 20, 2025 11:48
@graphite-app
Copy link

graphite-app bot commented May 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 20, 2025

Walkthrough

The pull request updates several GitHub Actions workflow files by removing the paths filter from the pull_request triggers, allowing workflows to run on all pull requests regardless of which files are changed. Additionally, minor formatting changes such as adding blank lines or newlines are included in some workflow files.

Changes

Files Change Summary
.github/workflows/lint-go.yml
.github/workflows/lint-spellcheck.yml
.github/workflows/test.yml
.github/workflows/upgrade-test.yml
Removed paths filters from pull_request triggers, so workflows now run on all PRs, not just those affecting certain files.
.github/workflows/nightly.yml
.github/workflows/release-from-tag.yml
Added a blank line or newline for formatting; no changes to workflow logic or triggers.

Possibly related PRs

  • Fix CI error #635: Modifies .github/workflows/upgrade-test.yml by replacing a commented-out workflow with a minimal active workflow, showing a related context of changes to the same workflow file.

Suggested reviewers

  • neekolas

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@macroscopeapp
Copy link

macroscopeapp bot commented May 20, 2025

Remove path filtering from GitHub CI workflows to run on all pull requests

Modifies GitHub workflow configurations to remove path-based filtering on pull request triggers:

📍Where to Start

Start with the pull request trigger configuration in lint-go.yml as it represents the pattern of changes applied across all workflow files.


Macroscope summarized 0805238.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/upgrade-test.yml (1)

7-8: Optional: Limit PR triggers to code changes only

Without any filters, this workflow will fire on all PR events (comments, labels, reviews, etc.). If you want to restrict runs to actual code updates, consider adding a types: filter:

on:
  pull_request:
    types:
      - opened
      - synchronize
      - reopened

This helps avoid unnecessary CI jobs on non-code events.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 104fde4 and 0805238.

📒 Files selected for processing (6)
  • .github/workflows/lint-go.yml (1 hunks)
  • .github/workflows/lint-spellcheck.yml (1 hunks)
  • .github/workflows/nightly.yml (1 hunks)
  • .github/workflows/release-from-tag.yml (1 hunks)
  • .github/workflows/test.yml (1 hunks)
  • .github/workflows/upgrade-test.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test (Node)
🔇 Additional comments (7)
.github/workflows/nightly.yml (1)

6-6: Formatting Adjustment: Added Spacing After Trigger

The blank line after workflow_dispatch: enhances readability and maintains consistency with other workflow files.

.github/workflows/release-from-tag.yml (1)

60-60: Formatting Enhancement: Blank Line Before build-args

Inserting a blank line improves readability by visually separating labels and build-args within the with block. This aligns with formatting in other workflows.

.github/workflows/lint-spellcheck.yml (1)

6-7: Removed paths Filter to Trigger on All Pull Requests

The paths filter was removed from the pull_request trigger, enabling this workflow to run on every PR to main (regardless of changed files), aligning with the CI simplification objective.

.github/workflows/test.yml (1)

7-8: Removed paths Filter to Broaden PR Trigger

By deleting the paths restriction under pull_request and adding a blank line, this workflow now runs on all pull requests. This aligns with the intended CI behavior change.

.github/workflows/lint-go.yml (2)

6-7: Removed paths Filter from pull_request Trigger

The removal of the paths restriction ensures the lint-go workflow runs on any PR to main, consistent with the CI policy update.


10-10: Formatting Enhancement: Blank Line Between permissions and jobs

Adding a blank line improves visual separation between the permissions block and job definitions.

.github/workflows/upgrade-test.yml (1)

7-8: Removed paths filter to trigger on all pull requests

The paths filter has been removed under the pull_request event, aligning this workflow with the other CI pipelines (lint-go, lint-spellcheck, test) so that upgrade tests run on every PR regardless of which files were modified. Please confirm that this broader trigger is intentional, as it will increase CI runs and may impact resource usage.

@mkysel mkysel merged commit 4a223be into main May 20, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/ci branch May 20, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants