Speed up CLI container construction in dev/up

[mkysel]

Reduce CLI container build time by consolidating image configurations and forcing rebuilds in dev environment

• Consolidates duplicate CLI container configurations in docker-compose-register.yml using YAML anchors with a shared x-cli-image definition
• Adds --build flag to docker compose up command in up script to ensure containers use latest code changes

📍Where to Start

Start with the YAML anchor definition x-cli-image in docker-compose-register.yml which defines the common build configuration now used across all CLI services.

---

Macroscope summarized a6e4b25.

Summary by CodeRabbit

• Chores
  • Improved Docker Compose configuration for register node services to reduce redundancy.
  • Updated the startup script to ensure Docker images are rebuilt before launching register node services.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• Queue - adds this PR to the back of the merge queue
• Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[coderabbitai]

Walkthrough

The docker-compose configuration for CLI-related services was refactored to use a YAML anchor for shared build and image settings, reducing redundancy. Additionally, the script that starts these services was updated to always rebuild images before launching containers, ensuring changes in the build context are applied.

Changes

File(s)	Change Summary
dev/docker/docker-compose-register.yml	Refactored to use a YAML anchor (cli-image) for shared build context, Dockerfile, and image fields across CLI-related services, removing redundant configuration.
dev/docker/up	Updated to add the --build flag to the docker compose up command for register services, ensuring images are rebuilt before starting containers.

Possibly related PRs

• Register nodes in docker up #704: Introduces the node registration services and profile-based Docker Compose usage, which relates to this PR as both modify the same docker-compose-register.yml and up script, though with different focuses (service introduction vs. configuration simplification and build process adjustment).

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a223be and a6e4b25.

📒 Files selected for processing (2)

• dev/docker/docker-compose-register.yml (4 hunks)
• dev/docker/up (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Test (Node)

🔇 Additional comments (3)

dev/docker/docker-compose-register.yml (2)

1-5: Good YAML structure optimization.

Creating a reusable YAML anchor for the CLI image configuration is an excellent way to reduce duplication across multiple services. This approach follows the DRY (Don't Repeat Yourself) principle and makes the configuration more maintainable.

---

9-9: Consistent anchor reference implementation.

Consistently applying the YAML anchor reference across all four services ensures uniform configuration. This approach simplifies future maintenance as any changes to the build context or image only need to be made in one place.

Also applies to: 25-25, 42-42, 61-61

dev/docker/up (1)

30-30: Important build flag addition ensures image freshness.

Adding the --build flag is crucial here as it ensures Docker rebuilds images before launching containers. This perfectly complements the YAML anchor refactoring in docker-compose-register.yml, guaranteeing that any changes to the build context or Dockerfile are properly incorporated before services start.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.