-
Notifications
You must be signed in to change notification settings - Fork 39
Do not require BIN for abigen #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change removes all deprecated contract deployment functions and associated compiled bytecode variables from several Ethereum contract binding packages. The affected packages now only provide bindings for interacting with already deployed contracts, and no longer support deploying new contract instances directly through their Go APIs. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (7)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Remove binary file requirements from abigen script and eliminate contract deployment functionality from generated Go bindings
The changes remove binary file (.bin.json) handling from the contract code generation process and eliminate deployment functionality from all generated Go contract bindings:
• Modified dev/gen/abi script to remove binary file downloading and the
--binparameter fromgo tool abigencommand• Removed
Binfields, binary variables, andDeploy*functions from seven contract bindings:GroupMessageBroadcaster,IdentityUpdateBroadcaster,NodeRegistry,PayerRegistry,PayerReportManager,RateRegistry, andSettlementChainParameterRegistry• Generated Go bindings now only contain ABI-based functionality for interacting with existing contracts, not deploying new ones
📍Where to Start
Start with the dev/gen/abi script to understand how the binary file requirements were removed from the code generation process.
Macroscope summarized 3bd15c0.
Summary by CodeRabbit