Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jun 3, 2025

Update contracts Docker image version from v0.4.0 to v0.4.3 across development environment configurations and test utilities

This pull request updates the contracts Docker image version from v0.4.0 to v0.4.3 across multiple configuration files:

• Updates Docker Compose configuration in docker-compose.yml to use the newer contracts image
• Updates all contract addresses in anvil.json and adds new configuration entries for app chain and settlement chain components including factories, gateways, and parameter registries
• Updates the Docker image version in the StartAnvil function within anvil.go for test container creation

📍Where to Start

Start with the Docker Compose configuration in docker-compose.yml to see the primary image version update, then review the contract address changes in anvil.json.


Macroscope summarized 5017753.

Summary by CodeRabbit

  • Chores
    • Updated the Docker Compose and test utility configurations to use a newer container image version for improved consistency.
    • Refreshed the Anvil environment configuration with new and updated Ethereum contract addresses.

@mkysel mkysel requested a review from a team as a code owner June 3, 2025 15:03
@graphite-app
Copy link

graphite-app bot commented Jun 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 3, 2025

Walkthrough

The updates include changing the Docker image version for the chain service and the Anvil test environment to v0.4.3, and modifying the Anvil environment's JSON configuration with new and updated Ethereum contract addresses. No changes were made to exported or public entities in Go code.

Changes

File(s) Change Summary
dev/docker/docker-compose.yml Updated chain service Docker image tag from v0.4.0 to v0.4.3.
pkg/testutils/anvil/anvil.go Updated Anvil container request image version from v0.4.0 to v0.4.3.
dev/environments/anvil.json Added new contract address entries and updated existing addresses for Anvil environment config.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant DockerCompose
    participant AnvilTestEnv
    participant ContractContainer

    Developer->>DockerCompose: Start chain service
    DockerCompose->>ContractContainer: Pull image v0.4.3
    DockerCompose->>ContractContainer: Launch container

    Developer->>AnvilTestEnv: Start Anvil test environment
    AnvilTestEnv->>ContractContainer: Pull image v0.4.3
    AnvilTestEnv->>ContractContainer: Launch container with updated addresses
Loading

Possibly related PRs

Suggested reviewers

  • neekolas

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7bc51c and 5017753.

📒 Files selected for processing (3)
  • dev/docker/docker-compose.yml (1 hunks)
  • dev/environments/anvil.json (1 hunks)
  • pkg/testutils/anvil/anvil.go (1 hunks)
🧰 Additional context used
🪛 Gitleaks (8.26.0)
dev/environments/anvil.json

6-6: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

🔇 Additional comments (4)
pkg/testutils/anvil/anvil.go (1)

74-74: Align Anvil container image version to v0.4.3
The image tag has been correctly bumped from v0.4.0 to v0.4.3, matching the Docker Compose update.

Please verify that any documentation or CI pipelines referencing the old version are updated accordingly.

dev/docker/docker-compose.yml (1)

22-22: Bump chain service image tag to v0.4.3
This change ensures the local development environment uses the latest contracts release.

dev/environments/anvil.json (2)

3-15: Update appChain contract addresses for v0.4.3 deployments
The appChainFactory, gateway, token, registry, deployer, distribution manager, message broadcaster, identity broadcaster, node registry, payer registry, report manager, and rate registry addresses have all been updated.

Please validate these addresses against the v0.4.3 deployment artifacts or a checksum utility to ensure they are correct.

🧰 Tools
🪛 Gitleaks (8.26.0)

6-6: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)


17-20: Update settlementChain contract addresses for v0.4.3 deployments
The settlementChainFactory, gateway, and parameter registry values have been updated.

Consider adding a JSON schema or a CI check to catch invalid or missing contract addresses in the future.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkysel mkysel merged commit f8358a1 into main Jun 3, 2025
10 checks passed
@mkysel mkysel deleted the mkysel/043 branch June 3, 2025 15:18
fbac pushed a commit that referenced this pull request Jun 4, 2025
### Update contracts Docker image version from v0.4.0 to v0.4.3 across
development environment configurations and test utilities
This pull request updates the contracts Docker image version from v0.4.0
to v0.4.3 across multiple configuration files:

• Updates Docker Compose configuration in
[docker-compose.yml](https://github.com/xmtp/xmtpd/pull/864/files#diff-6a25daaa729d7279e0cda8eb92399f1a82d4a91f961e1955bb5745e9c99f3c6e)
to use the newer contracts image
• Updates all contract addresses in
[anvil.json](https://github.com/xmtp/xmtpd/pull/864/files#diff-88c3cfe1e54eada0ee89bd90b61152ffa372ae06e03cd28131ab004db20e7075)
and adds new configuration entries for app chain and settlement chain
components including factories, gateways, and parameter registries
• Updates the Docker image version in the `StartAnvil` function within
[anvil.go](https://github.com/xmtp/xmtpd/pull/864/files#diff-da4e60931779e2d1dd0aef8398233cc17d7c421cefea0d43d327120c7748a611)
for test container creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants