Skip to content

Conversation

@fbac
Copy link
Collaborator

@fbac fbac commented Jun 18, 2025

Log replication metrics shutdown by improving error handling in metrics server and adding signal logging to server shutdown process

  • Modifies error handling in the metrics server goroutine in metrics.go to differentiate between normal shutdown errors (http.ErrServerClosed, net.ErrClosed) which are logged at info level and unexpected errors which are logged as errors
  • Adds logging of the specific OS signal that triggered server shutdown in the WaitForShutdown method of ReplicationServer in server.go

📍Where to Start

Start with the metrics server goroutine error handling changes in metrics.go.


Macroscope summarized 8e99dca.

@fbac fbac requested a review from a team as a code owner June 18, 2025 10:37
@graphite-app
Copy link

graphite-app bot commented Jun 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@fbac fbac merged commit 3e1f383 into main Jul 1, 2025
9 checks passed
@fbac fbac deleted the 06-18-shutdown_errors branch July 1, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants