Log replication.metrics shutdown #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log replication metrics shutdown by improving error handling in metrics server and adding signal logging to server shutdown process
http.ErrServerClosed,net.ErrClosed) which are logged at info level and unexpected errors which are logged as errorsWaitForShutdownmethod ofReplicationServerin server.go📍Where to Start
Start with the metrics server goroutine error handling changes in metrics.go.
Macroscope summarized 8e99dca.