Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jun 23, 2025

Fix backfill block size off-by-1 error in RpcLogStreamer.GetNextPage method to ensure exactly backfillBlockPageSize blocks are queried per page

The toBlock calculation in the GetNextPage method of RpcLogStreamer is corrected by subtracting 1 from fromBlockNumber + r.backfillBlockPageSize to prevent querying one extra block per page. A comment is added to explain the fix in rpc_log_streamer.go.

📍Where to Start

Start with the GetNextPage method in rpc_log_streamer.go.

Changes since #903 opened

  • Corrected block range calculations in RPC log streamer test mocks [fff8f24]
  • Updated backfill page size configuration [fff8f24]
  • Modified test assertion methods for type flexibility [fff8f24]

Macroscope summarized fff8f24.

@mkysel mkysel requested a review from a team as a code owner June 23, 2025 16:46
@graphite-app
Copy link

graphite-app bot commented Jun 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit 80fd5ab into main Jun 23, 2025
9 checks passed
@mkysel mkysel deleted the mkysel/fix-backfill-block-size branch June 23, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants