Fix backfill block size off-by-1 #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix backfill block size off-by-1 error in RpcLogStreamer.GetNextPage method to ensure exactly backfillBlockPageSize blocks are queried per page
The
toBlockcalculation in theGetNextPagemethod ofRpcLogStreameris corrected by subtracting 1 fromfromBlockNumber + r.backfillBlockPageSizeto prevent querying one extra block per page. A comment is added to explain the fix in rpc_log_streamer.go.📍Where to Start
Start with the
GetNextPagemethod in rpc_log_streamer.go.Changes since #903 opened
Macroscope summarized fff8f24.