Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jun 23, 2025

We already have the v1/health GRPC endpoint and HTTP healthz. Our sync/indexer service without API was depending on metrics which is less robust than the existing code.

@mkysel mkysel requested a review from a team as a code owner June 23, 2025 20:58
@graphite-app
Copy link

graphite-app bot commented Jun 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Jun 23, 2025

Always run API server with /healthz endpoint regardless of Payer or Replication service configuration

The server now unconditionally starts the API server instead of only starting it when Payer or Replication services are enabled. The conditional check in server.go has been removed to ensure the API server and its /healthz endpoint are always available. Test utilities have been refactored to use structured configuration objects (TestServerCfg and EnabledServices structs) in server.go, and new health endpoint tests have been added in server_test.go to verify both gRPC and HTTP health checks return SERVING status when no services are explicitly enabled.

📍Where to Start

Start with the server startup logic in server.go where the conditional check for starting the API server has been removed.


Macroscope summarized c8f2973.

@mkysel mkysel merged commit b70a678 into main Jun 23, 2025
9 of 10 checks passed
@mkysel mkysel deleted the mkysel/healthz branch June 23, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants