Silence error during shutdown #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
fbac
approved these changes
Jun 25, 2025
mkysel
force-pushed
the
mkysel/silence-error
branch
from
ab57988 to
ae656f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence error logging during shutdown in syncWorker.subscribeToNodeRegistration method to prevent unnecessary error logs when context is canceled
Modifies the error logging condition in the
subscribeToNodeRegistrationfunction within pkg/sync/syncWorker.go to add a context cancellation check. The function now only logs connection errors whens.ctx.Err() == nil, preventing error messages from being logged when connections are terminated due to normal context cancellation during shutdown.📍Where to Start
Start with the
subscribeToNodeRegistrationfunction in pkg/sync/syncWorker.go.Macroscope summarized ae656f5.