Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jun 25, 2025

Remove TargetOriginator field from AuthenticatedData structure and update protobuf definitions to use main branch

  • Removes the TargetOriginator field from the AuthenticatedData structure in pkg/proto/xmtpv4/envelopes/envelopes.pb.go, eliminating explicit originator targeting for message routing
  • Updates the protobuf generation script in dev/gen/protos to use the main branch instead of a specific feature branch
  • Modifies the payer service in pkg/api/payer/service.go to remove backwards compatibility code for TargetOriginator and simplifies blockchain routing logic to only check IsCommit flag
  • Removes test function TestMismatchingAADOriginatorOnPublishNoLongerFails and updates multiple test files to remove TargetOriginator field usage
  • Adds new backup element types for events and welcome message encryption algorithm fields to various protobuf definitions

📍Where to Start

Start with the AuthenticatedData structure in pkg/proto/xmtpv4/envelopes/envelopes.pb.go to see the removal of the TargetOriginator field, then review the payer service changes in pkg/api/payer/service.go.


Macroscope summarized 36d6d29.

@mkysel mkysel requested a review from a team as a code owner June 25, 2025 15:19
@graphite-app
Copy link

graphite-app bot commented Jun 25, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel merged commit b875869 into main Jun 25, 2025
9 checks passed
@mkysel mkysel deleted the mkysel/update-protos branch June 25, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants