Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jun 30, 2025

Our existing logging such as


{
--
 
caller | replication.syncWorker

{
caller	
replication.syncWorker

envelope
{

UnsignedOriginatorEnvelope
{

PayerEnvelope
{
TargetOriginator	
100
}
}
}
http_address	
https://grpc.testnet-dev.xmtp.network/

lastEnvelope
{

UnsignedOriginatorEnvelope
{

PayerEnvelope
{
TargetOriginator	
100
}
}
}
level	
ERROR
originator_id	
100
service	
xmtpd-server-sync
source	
stdout
timestamp	
1750968572803
}

was useless

@mkysel mkysel requested a review from a team as a code owner June 30, 2025 18:26
@graphite-app
Copy link

graphite-app bot commented Jun 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Jun 30, 2025

Print specific data fields for out-of-order envelope errors in originatorStream.validateEnvelope method

The error logging in the validateEnvelope method of the originatorStream struct now logs specific relevant fields instead of entire envelope objects when out-of-order envelopes are detected. The logged fields include expectedSequenceID, actualSequenceID, lastTimestampNs, actualTimestampNs, and originatorId. The error message text is updated from "Received out of order envelope" to "Received out-of-order envelope" with proper hyphenation. Changes are made in pkg/sync/originatorStream.go.

📍Where to Start

Start with the validateEnvelope method in the originatorStream struct in pkg/sync/originatorStream.go.


Macroscope summarized 45a9458.

@mkysel mkysel enabled auto-merge (squash) June 30, 2025 18:29
@mkysel
Copy link
Collaborator Author

mkysel commented Jun 30, 2025

I think that the entire warning needs to go. It does not work as expected in HA.

@mkysel mkysel merged commit cecce9b into main Jun 30, 2025
9 checks passed
@mkysel mkysel deleted the mkysel/better-log branch June 30, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants