Skip to content

Conversation

@fbac
Copy link
Collaborator

@fbac fbac commented Jul 9, 2025

Add GetVersion metadata endpoint to return server version information

The metadata API service now includes a GetVersion RPC method that returns the server's version as a string. The changes include:

  • Add version field to Service struct in pkg/api/metadata/service.go and update constructor to accept version parameter
  • Generate protobuf definitions and gRPC service code for GetVersionRequest and GetVersionResponse message types
  • Update server initialization in pkg/server/server.go to pass cfg.ServerVersion to metadata service constructor
  • Add mock implementations for testing the new GetVersion method
  • Generate OpenAPI/Swagger documentation for the new /mls/v2/metadata/version POST endpoint

📍Where to Start

Start with the GetVersion method implementation in the Service struct in pkg/api/metadata/service.go.


Macroscope summarized 46c2a48.

@fbac fbac requested a review from a team as a code owner July 9, 2025 16:04
@graphite-app
Copy link

graphite-app bot commented Jul 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@fbac
Copy link
Collaborator Author

fbac commented Jul 9, 2025

This is just a convenient endpoint to have, giving us visibility on all the nodes in the network. Also, will help during migration.

@fbac fbac mentioned this pull request Jul 10, 2025
@fbac fbac merged commit e974f4e into main Jul 10, 2025
9 checks passed
@fbac fbac deleted the 07-09-metadata_version_endpoint branch July 10, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants