Guarantee data integrity after sub fails completely #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
mkysel
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change RPCLogStreamer.watchContract method to terminate application instead of gracefully stopping when subscription rebuilding fails to guarantee data integrity after sub fails completely
The error handling in the
RPCLogStreamer.watchContractmethod in rpc_log_streamer.go is modified to calllogger.Fatal()instead of logging an error and callingr.Stop()when subscription rebuilding fails after the maximum disconnect time. This change occurs in two locations within the method and causes the application to terminate rather than attempt graceful shutdown when persistent connection failures occur.📍Where to Start
Start with the
RPCLogStreamer.watchContractmethod in rpc_log_streamer.go where the error handling behavior has been modified.Macroscope summarized 534f60c.