Skip to content

Conversation

@pingshuijie
Copy link
Contributor

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Signed-off-by: pingshuijie <pingshuijie@outlook.com>
@pingshuijie pingshuijie requested a review from a team as a code owner July 22, 2025 10:41
@graphite-app
Copy link

graphite-app bot commented Jul 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@macroscopeapp
Copy link

macroscopeapp bot commented Jul 22, 2025

Replace manual map copying with maps.Copy in XmtpdContainerBuilder.WithEnvVars method for cleaner map handling

The WithEnvVars method in the XmtpdContainerBuilder struct now uses the standard library maps.Copy function instead of manually iterating through map entries. The change adds an import for the maps package and replaces the manual loop-based copying with maps.Copy(b.envVars, envVars) in pkg/integration/docker_utils_test.go.

📍Where to Start

Start with the WithEnvVars method in the XmtpdContainerBuilder struct in pkg/integration/docker_utils_test.go.


Macroscope summarized d428374.

@mkysel mkysel merged commit 04daf2d into xmtp:main Jul 22, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants