Upgrade to v0.5.1 contracts #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
added 2 commits
July 23, 2025 14:45
fbac
force-pushed
the
07-23-contracts_0.5.0
branch
from
1943044 to
2d18ac8
Compare
mkysel
reviewed
Jul 24, 2025
Collaborator
mkysel
left a comment
mkysel
left a comment
There was a problem hiding this comment.
LGTM. Let me know when its ready
Collaborator
Author
Sure, this is blocked until MinutesSinceEpoch is stored onchain as part of the PayerReport struct. |
mkysel
approved these changes
Jul 28, 2025
fbac
force-pushed
the
07-23-contracts_0.5.0
branch
from
94d5b4b to
903d30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade contract bindings to v0.5.1 and change group ID size from 32 bytes to 16 bytes across blockchain publisher interfaces
Updates contract bindings to v0.5.1 with changes to parameter key return types from byte arrays to strings across multiple contracts, reduces group ID size from 32 bytes to 16 bytes in blockchain publisher interfaces, and adds new functionality for payload bootstrapping and underlying token operations:
[]bytetostringin IdentityUpdateBroadcaster.go, PayerRegistry.go, SettlementChainParameterRegistry.go, NodeRegistry.go, and RateRegistry.go[32]byteto[16]byteinPublishGroupMessagemethod across blockchainPublisher.go, interface.go, and related test filesBootstrapIdentityUpdates,PayloadBootstrapper, andUpdatePayloadBootstrapperto IdentityUpdateBroadcaster.goDepositFromUnderlying,DepositFromUnderlyingWithPermit, andFinalizeWithdrawalIntoUnderlyingto PayerRegistry.goendMinuteSinceEpochparameter to payer report structure in report.go and updates related functions📍Where to Start
Start with the
PublishGroupMessagemethod in blockchainPublisher.go to understand the core change from 32-byte to 16-byte group IDs, then review the contract binding changes in IdentityUpdateBroadcaster.go to see the parameter key type changes and new functionality.Macroscope summarized 903d30a.