Skip to content

Conversation

@mkysel
Copy link
Collaborator

@mkysel mkysel commented Jul 28, 2025

Route app messages to the blockchain by removing IsCommit field from AuthenticatedData and implementing commit detection through message deserialization in the payer service

The system removes the IsCommit field from the AuthenticatedData structure and modifies commit detection to use message deserialization instead of authenticated data flags. The changes include:

  • Remove IsCommit field from AuthenticatedData in pkg/proto/xmtpv4/envelopes/envelopes.pb.go and update related test helpers
  • Modify shouldSendToBlockchain and determineRetentionPolicy functions in pkg/api/payer/service.go to use deserializer.IsGroupMessageCommit() for commit detection
  • Update publishToBlockchain function to use constants from contracts package for originator IDs instead of hardcoded values
  • Remove TestPublishCommitIsRejected test indicating commits are no longer rejected during publishing
  • Update protobuf definitions to rename EncryptedCommitLogEntry to SerializedCommitLogEntry and add signature fields
  • Add CommitLogSigner field to GroupMutableMetadataV1 for storing ED25519 private keys

📍Where to Start

Start with the shouldSendToBlockchain function in pkg/api/payer/service.go to understand how commit detection has changed from using the IsCommit field to message deserialization.


Macroscope summarized a459911.

@mkysel mkysel requested a review from a team as a code owner July 28, 2025 16:27
@graphite-app
Copy link

graphite-app bot commented Jul 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • Queue - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@mkysel mkysel mentioned this pull request Jul 28, 2025
@mkysel mkysel merged commit e1015d4 into main Jul 28, 2025
9 checks passed
@mkysel mkysel deleted the mkysel/payer-routing branch July 28, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants