Route app messages to the blockchain #992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route app messages to the blockchain by removing IsCommit field from AuthenticatedData and implementing commit detection through message deserialization in the payer service
The system removes the
IsCommitfield from theAuthenticatedDatastructure and modifies commit detection to use message deserialization instead of authenticated data flags. The changes include:IsCommitfield fromAuthenticatedDatain pkg/proto/xmtpv4/envelopes/envelopes.pb.go and update related test helpersshouldSendToBlockchainanddetermineRetentionPolicyfunctions in pkg/api/payer/service.go to usedeserializer.IsGroupMessageCommit()for commit detectionpublishToBlockchainfunction to use constants from contracts package for originator IDs instead of hardcoded valuesTestPublishCommitIsRejectedtest indicating commits are no longer rejected during publishingEncryptedCommitLogEntrytoSerializedCommitLogEntryand add signature fieldsCommitLogSignerfield toGroupMutableMetadataV1for storing ED25519 private keys📍Where to Start
Start with the
shouldSendToBlockchainfunction in pkg/api/payer/service.go to understand how commit detection has changed from using theIsCommitfield to message deserialization.Macroscope summarized a459911.