Engine DB 3.0.1 schema support #166
Conversation
|
Many thanks for this PR, @danielkinahan. Your changes have also highlighted some areas in the code where I think things could be better explained, so I'll make a note to improve this: #168. Note that for some reason Github Actions is not seeing the unit tests, so it's mistakenly marking them green - raised #167 for this separately. |
|
I've implemented the changes you suggested. We will wait to merge this until you get those library dumps and we can test the Mixxx integration. |
Remove non-existent files from install stage (xsco#169)
|
I just tested this and it worked great. Once we get the firmware we should be good to. |
|
@mr-smidge did you get a chance to get that firmware? If you want I can pull it |
I haven't forgotten 😄 ... working on this now, in fact! |
|
@danielkinahan I've now merged ddeb427 - if you rebase on latest main then you should be able to make use of the new testdata in your PR. |
|
Thanks for adding that! The tests revealed that the schema was 3.0.1 and not 3.1.0 so i've made those changes. Also I am getting tons of errors on testing schemas 1.X.X but I think those might not be related to my changes. |
danielkinahan
changed the title
What are the errors you were seeing on 1.x schemas? I've checked out your branch, and can't replicate any problems - and nor can Github Actions! |
Co-authored-by: Adam Szmigin <smidge@xsco.net>
|
@danielkinahan now that #174 is merged (which I believe fixes #173), please can you rebase this on latest main? If all looks good on your side with the tests, we're good to merge! |
|
Awesome! Happy to get this merged. When you make the tag could you let me know? I'd like to submit the PR on mixxx to update it 😄 |
Tag 0.27.0 now pushed 👍. |
2 participants
For #165
This adds the 2 new triggers for performance and removes the old one.
I wasn't sure how you like to re-use the code between schemas so I've left the entirety of the schema for 3.0.0 in there. Also, I wasn't able to get the tests to pass on my own machine even with the code in the main branch so please let me know if there are any additional failures as a result of this change.