Skip to content

Unit tests now run in Github CI #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-smidge merged 1 commit into from
Nov 4, 2025
Merged

Unit tests now run in Github CI #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
{ os: ubuntu-24.04, c_compiler: clang-17, cpp_compiler: clang++-17 },
{ os: ubuntu-24.04, c_compiler: gcc-13, cpp_compiler: g++-13 },
{ os: ubuntu-24.04, c_compiler: gcc-14, cpp_compiler: g++-14 },
{ os: macos-13, c_compiler: cc, cpp_compiler: c++, cmake_args: "-DSYSTEM_SQLITE=OFF" },
{ os: macos-14, c_compiler: cc, cpp_compiler: c++, cmake_args: "-DSYSTEM_SQLITE=OFF" },
{ os: macos-15, c_compiler: cc, cpp_compiler: c++, cmake_args: "-DSYSTEM_SQLITE=OFF" },
{ os: windows-2022, c_compiler: cl, cpp_compiler: cl },
{ os: windows-2025, c_compiler: cl, cpp_compiler: cl },
]
Expand All @@ -38,17 +39,24 @@ jobs:

- name: Install dependencies (macOS)
if: runner.os == 'macOS'
run: brew install zlib
# Note: separate commands for main deps and test deps
run: |
brew install zlib
brew install boost

- name: Install dependencies (Ubuntu)
if: runner.os == 'Linux'
# Note: separate commands for main deps and test deps
run: |
sudo apt-get update
sudo apt-get install --yes libz-dev libsqlite3-dev
sudo apt-get install --yes libboost-filesystem-dev libboost-test-dev

- name: Install dependencies (Windows)
if: runner.os == 'Windows'
run: vcpkg install zlib sqlite3
# Note: test deps not currently installed for Windows as unit testing currently not supported for this platform.
run: |
vcpkg install zlib sqlite3

- name: Configure CMake (non-Windows)
if: runner.os != 'Windows'
Expand All @@ -64,5 +72,10 @@ jobs:
- name: Test
if: runner.os != 'Windows'
working-directory: ${{github.workspace}}/build
run: ctest -C ${{env.BUILD_TYPE}}

run: ctest -C ${{env.BUILD_TYPE}} --output-on-failure

- name: Install (non-Windows)
if: runner.os != 'Windows'
working-directory: ${{github.workspace}}/build
run: DESTDIR=. cmake --install .

42 changes: 21 additions & 21 deletions include/djinterop/exceptions.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

namespace djinterop
{
class database_not_found : public std::runtime_error
class DJINTEROP_PUBLIC database_not_found : public std::runtime_error
{
public:
explicit database_not_found(const std::string& what_arg) noexcept :
Expand All @@ -40,7 +40,7 @@ class database_not_found : public std::runtime_error
/// The `database_inconsistency` exception is thrown when the schema of a
/// database does not match the expectations suggested by its reported version
/// number.
class database_inconsistency : public std::runtime_error
class DJINTEROP_PUBLIC database_inconsistency : public std::runtime_error
{
public:
explicit database_inconsistency(const std::string& what_arg) noexcept :
Expand All @@ -51,7 +51,7 @@ class database_inconsistency : public std::runtime_error

/// The `unsupported_database` exception is thrown when a database is
/// encountered that is not yet supported by this version of the library.
class unsupported_database : public std::runtime_error
class DJINTEROP_PUBLIC unsupported_database : public std::runtime_error
{
public:
explicit unsupported_database(const std::string& what_arg) noexcept :
Expand All @@ -64,7 +64,7 @@ class unsupported_database : public std::runtime_error
/// perform an operation that is not supported by the database, such as a
/// missing feature on the high-level API, or a feature only available in
/// certain database versions.
class unsupported_operation : public std::runtime_error
class DJINTEROP_PUBLIC unsupported_operation : public std::runtime_error
{
public:
explicit unsupported_operation(const std::string& what_arg) noexcept :
Expand All @@ -75,7 +75,7 @@ class unsupported_operation : public std::runtime_error

/// The `crate_deleted` exception is thrown when an invalid `crate` object is
/// used, i.e. one that does not exist in the database anymore.
class crate_deleted : public std::runtime_error
class DJINTEROP_PUBLIC crate_deleted : public std::runtime_error
{
public:
/// Constructs the exception for a given crate ID
Expand All @@ -93,7 +93,7 @@ class crate_deleted : public std::runtime_error

/// The `crate_database_inconsistency` exception is thrown when a database
/// inconsistency is found that correlates to a crate.
class crate_database_inconsistency : public database_inconsistency
class DJINTEROP_PUBLIC crate_database_inconsistency : public database_inconsistency
{
public:
/// Construct the exception for a given crate ID
Expand All @@ -112,7 +112,7 @@ class crate_database_inconsistency : public database_inconsistency

/// The `crate_already_exists` exception is thrown when a request is made to
/// create a crate with a name that already exists.
class crate_already_exists : public std::runtime_error
class DJINTEROP_PUBLIC crate_already_exists : public std::runtime_error
{
public:
/// Construct the exception.
Expand All @@ -124,7 +124,7 @@ class crate_already_exists : public std::runtime_error

/// The `crate_invalid_parent` exception is thrown when a crate parent is found
/// to be invalid.
class crate_invalid_parent : public std::runtime_error
class DJINTEROP_PUBLIC crate_invalid_parent : public std::runtime_error
{
public:
/// Construct the exception.
Expand All @@ -136,7 +136,7 @@ class crate_invalid_parent : public std::runtime_error

/// The `crate_invalid_name` exception is thrown when a crate name is found to
/// be invalid.
class crate_invalid_name : public std::runtime_error
class DJINTEROP_PUBLIC crate_invalid_name : public std::runtime_error
{
public:
/// Construct the exception for a given crate name.
Expand All @@ -155,7 +155,7 @@ class crate_invalid_name : public std::runtime_error

/// The `playlist_already_exists` exception is thrown when a request is made to
/// create a playlist with a name that already exists.
class playlist_already_exists : public std::runtime_error
class DJINTEROP_PUBLIC playlist_already_exists : public std::runtime_error
{
public:
/// Construct the exception.
Expand All @@ -167,7 +167,7 @@ class playlist_already_exists : public std::runtime_error

/// The `playlist_database_inconsistency` exception is thrown when a database
/// inconsistency is found that correlates to a playlist.
class playlist_database_inconsistency : public database_inconsistency
class DJINTEROP_PUBLIC playlist_database_inconsistency : public database_inconsistency
{
public:
/// Construct the exception for a given crate ID
Expand All @@ -179,7 +179,7 @@ class playlist_database_inconsistency : public database_inconsistency

/// The `playlist_deleted` exception is thrown when an invalid `playlist` object
/// is used, i.e. one that does not exist in the database anymore.
class playlist_deleted : public std::runtime_error
class DJINTEROP_PUBLIC playlist_deleted : public std::runtime_error
{
public:
/// Constructs the exception for a given playlist ID
Expand All @@ -197,7 +197,7 @@ class playlist_deleted : public std::runtime_error

/// The `playlist_invalid_parent` exception is thrown when a playlist parent is found
/// to be invalid.
class playlist_invalid_parent : public std::runtime_error
class DJINTEROP_PUBLIC playlist_invalid_parent : public std::runtime_error
{
public:
/// Construct the exception.
Expand All @@ -209,7 +209,7 @@ class playlist_invalid_parent : public std::runtime_error

/// The `playlist_invalid_name` exception is thrown when a playlist name is found to
/// be invalid.
class playlist_invalid_name : public std::runtime_error
class DJINTEROP_PUBLIC playlist_invalid_name : public std::runtime_error
{
public:
/// Construct the exception for a given playlist name.
Expand All @@ -228,7 +228,7 @@ class playlist_invalid_name : public std::runtime_error

/// The `track_deleted` exception is thrown when an invalid `track` object is
/// used, i.e. one that does not exist in the database anymore.
class track_deleted : public std::invalid_argument
class DJINTEROP_PUBLIC track_deleted : public std::invalid_argument
{
public:
/// Constructs the exception for a given track ID
Expand All @@ -246,7 +246,7 @@ class track_deleted : public std::invalid_argument

/// The `invalid_track_snapshot` exception is thrown when there is a problem
/// with a track snapshot.
class invalid_track_snapshot : public std::invalid_argument
class DJINTEROP_PUBLIC invalid_track_snapshot : public std::invalid_argument
{
public:
/// Initialise a new instance of the exception with a custom message.
Expand All @@ -258,7 +258,7 @@ class invalid_track_snapshot : public std::invalid_argument

/// The `track_database_inconsistency` exception is thrown when a database
/// inconsistency is found that correlates to a track.
class track_database_inconsistency : public database_inconsistency
class DJINTEROP_PUBLIC track_database_inconsistency : public database_inconsistency
{
public:
/// Construct the exception for a given track ID
Expand All @@ -277,7 +277,7 @@ class track_database_inconsistency : public database_inconsistency

/// The `track_already_in_playlist` exception is thrown when a request is made
/// to add a track a playlist it is already in.
class track_already_in_playlist : public std::invalid_argument
class DJINTEROP_PUBLIC track_already_in_playlist : public std::invalid_argument
{
public:
explicit track_already_in_playlist(const std::string& what_arg) noexcept :
Expand All @@ -289,7 +289,7 @@ class track_already_in_playlist : public std::invalid_argument
/// The `track_not_in_playlist` exception is thrown when a reference is made to
/// a track that is supposed to be in a playlist, but actually is not in the
/// playlist.
class track_not_in_playlist : public std::invalid_argument
class DJINTEROP_PUBLIC track_not_in_playlist : public std::invalid_argument
{
public:
explicit track_not_in_playlist(const std::string& what_arg) noexcept :
Expand All @@ -300,7 +300,7 @@ class track_not_in_playlist : public std::invalid_argument

/// The `hot_cues_overflow` exception is thrown when more hot cues are provided
/// than are supported by the database.
class hot_cues_overflow : public std::invalid_argument
class DJINTEROP_PUBLIC hot_cues_overflow : public std::invalid_argument
{
public:
/// Constructs the exception.
Expand All @@ -312,7 +312,7 @@ class hot_cues_overflow : public std::invalid_argument

/// The `loops_overflow` exception is thrown when more loops are provided than
/// are supported by the database.
class loops_overflow : public std::invalid_argument
class DJINTEROP_PUBLIC loops_overflow : public std::invalid_argument
{
public:
/// Constructs the exception.
Expand Down