Skip to content

Fix null optional deref in 1.x code #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-smidge merged 1 commit into from
Nov 29, 2025
Merged

Fix null optional deref in 1.x code #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/djinterop/engine/v1/engine_track_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@ high_res_waveform_data to_high_res_waveform_data(
std::optional<double> sample_rate,
const std::vector<waveform_entry>& waveform)
{
if (!sample_count || !sample_rate)
{
return high_res_waveform_data{0};
}

// Make the assumption that the client has respected the required number
// of samples per entry when constructing the waveform.
auto extents = util::calculate_high_resolution_waveform_extents(
Expand Down