XWIKI-21584: Mentions do not have enough contrast #2638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the default style of mentions
manuelleduc
reviewed
Nov 21, 2023
...form-mentions/xwiki-platform-mentions-ui/src/main/resources/XWiki/Mentions/MentionsMacro.xml
Outdated
Show resolved
Hide resolved
manuelleduc
approved these changes
Nov 21, 2023
Contributor
manuelleduc
left a comment
manuelleduc
left a comment
There was a problem hiding this comment.
Lgtm except for the border radius question. Thanks!
* Reverted changes on border radius
surli
reviewed
Dec 4, 2023
...form-mentions/xwiki-platform-mentions-ui/src/main/resources/XWiki/Mentions/MentionsMacro.xml
Outdated
Show resolved
Hide resolved
* Updated the name of the mention color parameters to better fit with the naming convention from the color theme * Added a parameter for the foreground color of the self mentions, with the default value similar to what was in its place previously
surli
reviewed
Dec 6, 2023
...form-mentions/xwiki-platform-mentions-ui/src/main/resources/XWiki/Mentions/Configuration.xml
Outdated
Show resolved
Hide resolved
surli
reviewed
Dec 6, 2023
...form-mentions/xwiki-platform-mentions-ui/src/main/resources/XWiki/Mentions/MentionsMacro.xml
Outdated
Show resolved
Hide resolved
* Removed the change in the service call * Added an update to a comment to make it clearer that this naming is poor
* Removed the name change in config and classes for the mentionColor
* Updated the translations * Replaced the new background variable with a new foreground variable to keep backward usability on the `color` variables
* Replaced the new background variable with a new foreground variable to keep backward usability on the `color` variables
* Fixed a prettyname
Contributor
Author
|
surli
reviewed
Aug 27, 2024
...form-mentions/xwiki-platform-mentions-ui/src/main/resources/XWiki/Mentions/MentionsMacro.xml
Outdated
Show resolved
Hide resolved
* Added the foreground getter as an API in the new script service.
Contributor
Author
|
Setting this PR as a draft until resolution of #2638 (comment) |
Contributor
Author
surli
reviewed
Jan 24, 2025
...iki-platform-mentions-api/src/main/java/org/xwiki/mentions/script/MentionsScriptService.java
Show resolved
Hide resolved
surli
reviewed
Jan 24, 2025
...ions/xwiki-platform-mentions-api/src/main/java/org/xwiki/mentions/MentionsConfiguration.java
Outdated
Show resolved
Hide resolved
* Added since annotations on the new script services. * Added a default return value for the default interface.
Contributor
Author
|
All comments have been addressed, this PR is ready for further review :) |
surli
reviewed
Jul 30, 2025
...mentions-default/src/main/java/org/xwiki/mentions/internal/DefaultMentionsConfiguration.java
Outdated
Show resolved
Hide resolved
surli
reviewed
Jul 30, 2025
Member
surli
left a comment
surli
left a comment
There was a problem hiding this comment.
Sounds good to me if you fix the default value to be consistent and if you set all @Since values to be 17.7.0RC1 now.
Contributor
|
Wouldn't it make more sense to move the color configuration to the color theme and use CSS variables to access them? I'm not saying this isn't okay as a "quick fix", I have just the feeling that from a technical/implementation point of view this is going in the wrong direction. In any case, it's good to address those last remaining contrast issues, thank you very much for that! |
Contributor
Author
Those variables are meant to be used exclusively by mentions so I don't think we want to make them part of the Flamingo ColorTheme. |
* Updated the version numbers. * Updated the styles to only rely on the CSS variables. * Fixed a small codestyle issue.
Contributor
Author
|
I tested the latest changes on my local instance: In addition, I reran quality builds:
And the mention docker tests: All of those passed successfully. |
Contributor
Author
|
The PR is ready for review or a merge. |
surli
reviewed
Dec 30, 2025
...iki-platform-mentions-api/src/main/java/org/xwiki/mentions/script/MentionsScriptService.java
Show resolved
Hide resolved
surli
reviewed
Dec 30, 2025
...ions/xwiki-platform-mentions-api/src/main/java/org/xwiki/mentions/MentionsConfiguration.java
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
* Updated the default style of mentions * Updated the name of the mention color parameters to better fit with the naming convention from the color theme * Added a parameter for the foreground color of the self mentions, with the default value similar to what was in its place previously * Updated the translations * Replaced the new background variable with a new foreground variable to keep backward usability on the `color` variables * Fixed a prettyname * Added the foreground getter as an API in the new script service. * Added since annotations on the new script services. * Added a default return value for the default interface. * Updated the version numbers. * Updated the styles to only rely on the CSS variables. * Fixed a small codestyle issue. --------- Co-authored-by: Simon Urli <simon.urli@gmail.com> (cherry picked from commit 006624f)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
surli
added a commit
that referenced
this pull request
Dec 30, 2025
* Updated the default style of mentions * Updated the name of the mention color parameters to better fit with the naming convention from the color theme * Added a parameter for the foreground color of the self mentions, with the default value similar to what was in its place previously * Updated the translations * Replaced the new background variable with a new foreground variable to keep backward usability on the `color` variables * Fixed a prettyname * Added the foreground getter as an API in the new script service. * Added since annotations on the new script services. * Added a default return value for the default interface. * Updated the version numbers. * Updated the styles to only rely on the CSS variables. * Fixed a small codestyle issue. --------- Co-authored-by: Simon Urli <simon.urli@gmail.com> (cherry picked from commit 006624f)
surli
added a commit
that referenced
this pull request
Dec 31, 2025
* Updated the default style of mentions * Updated the name of the mention color parameters to better fit with the naming convention from the color theme * Added a parameter for the foreground color of the self mentions, with the default value similar to what was in its place previously * Updated the translations * Replaced the new background variable with a new foreground variable to keep backward usability on the `color` variables * Fixed a prettyname * Added the foreground getter as an API in the new script service. * Added since annotations on the new script services. * Added a default return value for the default interface. * Updated the version numbers. * Updated the styles to only rely on the CSS variables. * Fixed a small codestyle issue. --------- Co-authored-by: Simon Urli <simon.urli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://jira.xwiki.org/browse/XWIKI-21584
PR Changes
View
Here,
123 456is a lambda user andAdministratoris the current user.vvv Before the PR
vvv After the PR
Note
This is a style change, but I also took the opportunity to remove hard-coded transparent colors. Hard coded is against best practice, and adding transparency does not make sense in this context, the mention is too small to cover anything.