XWIKI-22931: The edit action modify the cached document when creating a page from template #3943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
commented
Feb 27, 2025
...form-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated
Show resolved
Hide resolved
surli
commented
Mar 5, 2025
...m-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java
Outdated
Show resolved
Hide resolved
surli
commented
Mar 5, 2025
...form-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated
Show resolved
Hide resolved
tmortagne
reviewed
Mar 10, 2025
...form-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java
Outdated
Show resolved
Hide resolved
… a page from template
* Fix XWikiDocument#copyAttachment to actually perform a real clone
including the copy of the content
* Introduce a XWikiAttachment#cloneWithActualContent to clone and copy
the content
* Introduce a XWikiAttachmentContent#clone(boolean) that allows to
decide to skip or not copying the content
WIP: right now tests are passing but it shows a regression in logs when
running PageTemplatesIT, probably due to the ownerDocument of
XWikiAttachmnentContent in clone method
… a page from template * Get rid of ownerDocument in XWikiAttachmentContent * Properly override new clone method in extended classes * Set the attachment document in XWikiDocument#setAttachment WIP: this still shows a regression in PageTemplatesIT with a stacktrace about a missing attachment.
… a page from template
* Small improvments but still having bad stack trace when trying to
create page from template related to Solr
… a page from template * Properly load the file content before cloning it WIP: there's still a problem with the template UC
… a page from template * Fix override
… a page from template * Fix since
Member
|
The logic looks OK in general, but there are some pretty dangerous changes in there and I feel like they deserve better test coverage, it's so easy to break that kind of stuff... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22931
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
mvn clean install -Pqualityrun on:Tests ran for PageTemplatesIT
Manual test to create a page from Encyclopedia Template.
Note: CI run triggered in https://ci.xwiki.org/view/All/job/XWiki/job/xwiki-platform/job/XWIKI-22931/
Expected merging strategy