CRISTAL-734: Allow overriding the image insertion UI #4953
Conversation
|
@ClementEXWiki shouldn't the Jira issue be moved in the XWIKI project, and the PR name updated accordingly? |
| export function extractMacroRawContent(content: InlineContent<DefaultInlineContentSchema, DefaultStyleSchema>[]): string; | ||
|
|
||
| // @beta | ||
| export type ImageEditionOverrideFn = (image: BlockOfType<"image">, update: (newProps: Partial<BlockOfType<"image">["props"]>) => void) => void; |
There was a problem hiding this comment.
WDYT about making this an async function instead, that returns a Promise<Partial<BlockOfType<"image">["props"]>>. If the promise is rejected it means the user has canceled the image edit. Otherwise, if the promise is resolved then the editor will use the resolved image properties to update the image.
I'm wondering if we need to have access to the image block or if the image properties are enough as input. I'm tempted to say that having the image properties as input is enough, because the goal is to edit those properties. The only use case I have in mind when the image block might be useful is if we want to display a popover instead of a modal, in which case we may need the position of the image block on the screen. But we'll start with a modal for sure. WDYT?
| if (imageEditionOverrideFn) { | ||
| imageEditionOverrideFn(currentBlock, updateImageProps); | ||
| } else { | ||
| setShowLinkEditor(true); |
There was a problem hiding this comment.
You open the link editor because there is no dedicated image editor yet on Cristal side, right?
| /** | ||
| * Overrides for default behavior | ||
| * | ||
| * @since 0.26 |
There was a problem hiding this comment.
We'll have to use XWiki versions now, right? So 18.0.0RC1.
There was a problem hiding this comment.
Definitely! Also, I have kept the existing @since annotations when moving the code, but I'm going to update all of them to 18.0.0RC1 as well.
3 participants
Jira URL
https://jira.xwiki.org/browse/CRISTAL-743
Changes
Description
blocknote-headlessClarifications
N/A
Screenshots & Video
N/A
Executed Tests
N/A
Expected merging strategy
*