XWIKI-23826: Refactor Cristal's navigation tree to separate logic and ds #4955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Force location of NavigationTreeNode to a SpaceReference instance * Remove no longer used XNavigationTree and XNavigationTreeSelect components definitions * Extend TreeProps definition and turn XTree into a generic component
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
manuelleduc
reviewed
Dec 18, 2025
| XTabPanel: DefineComponent<TabPanelProps & HTMLAttributes>; | ||
| XTextField: DefineComponent<TextFieldProps & ImgHTMLAttributes>; | ||
| XTree: DefineComponent<TreeProps & HTMLAttributes>; | ||
| XTree: DefineComponent<TreeProps<DisplayableTreeNode & any> & HTMLAttributes>; |
Contributor
There was a problem hiding this comment.
Isn't TreeProps<DisplayableTreeNode & any> equivalent to TreeProps<any>?
Contributor
Author
There was a problem hiding this comment.
There is a slight difference: it enforces the existing properties of DisplayableTreeNode to be present (which makes sense in this case since TreeProps is a generic type that requires a subclass of DisplayableTreeNode)
Contributor
There was a problem hiding this comment.
Right, maybe add a comment in the source to explain the logic as I might not be the only one to be confused by this.
* Add missing comment * Re-export TreeNode to make DisplayableTreeNode importable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23826
Changes
Description
This PR includes changes to some Cristal APIs (that are currently still in beta) to prepare for the release 1.0:
Clarifications
This PR is tied to xwiki-contrib/cristal#1493 and both should be merged at the same time.
Screenshots & Video
N/A
Executed Tests
The new API packages were built locally and used to test the linked Cristal PR.
Expected merging strategy