XWIKI-23634: JSX resources loaded twice when loading docextra tab UIX #4973
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the required skin extensions mechanism from display_macros.vm for loaddocextrauix.vm and commentsinline.vm. * Remove the duplicate loading of skin extensions as it isn't required anymore. * Fix display_macros.vm to actually filter out duplicates as it didn't actually work when on this page skin extensions were combined with on-demand ones.
surli
reviewed
Dec 30, 2025
| </div> ## commentscontent | ||
| #end ## comment == '' | ||
| #getRequiredSkinExtensions($requiredSkinExtensions) | ||
| #set ($discard = $response.setHeader('X-XWIKI-HTML-HEAD', $requiredSkinExtensions)) |
Member
There was a problem hiding this comment.
Shouldn't we declare a macro for that? Would avoid repeating the header name everywhere if we ever want to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23634
Changes
Description
Clarifications
Screenshots & Video
No UI changes.
Executed Tests
Manual tests only so far, automated tests are still missing.
Expected merging strategy